You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/17 02:46:52 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #28847: [SPARK-29148][CORE][FOLLOWUP] Fix warning message to show a correct executor id
dongjoon-hyun opened a new pull request #28847:
URL: https://github.com/apache/spark/pull/28847
### What changes were proposed in this pull request?
This aims to replace `executorIdsToBeRemoved` with `executorIdToBeRemoved`.
### Why are the changes needed?
Since a wrong variable is used currently, `ArrayBuffer()` is always displayed.
```
20/06/16 19:33:31 WARN ExecutorAllocationManager: Not removing executor ArrayBuffer() because the ResourceProfile was UNKNOWN!
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manual.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28847: [SPARK-29148][CORE][FOLLOWUP] Fix warning message to show a correct executor id
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28847:
URL: https://github.com/apache/spark/pull/28847#issuecomment-645167716
**[Test build #124151 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124151/testReport)** for PR 28847 at commit [`c195a7f`](https://github.com/apache/spark/commit/c195a7fb321a646e2d016b173b51983c2bcda4c8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #28847: [SPARK-29148][CORE][FOLLOWUP] Fix warning message to show a correct executor id
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #28847:
URL: https://github.com/apache/spark/pull/28847#issuecomment-645373089
thanks for fixing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28847: [SPARK-29148][CORE][FOLLOWUP] Fix warning message to show a correct executor id
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28847:
URL: https://github.com/apache/spark/pull/28847#issuecomment-645115062
cc @tgravescs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28847: [SPARK-29148][CORE][FOLLOWUP] Fix warning message to show a correct executor id
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28847:
URL: https://github.com/apache/spark/pull/28847
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28847: [SPARK-29148][CORE][FOLLOWUP] Fix warning message to show a correct executor id
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28847:
URL: https://github.com/apache/spark/pull/28847#issuecomment-645114911
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28847: [SPARK-29148][CORE][FOLLOWUP] Fix warning message to show a correct executor id
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28847:
URL: https://github.com/apache/spark/pull/28847#issuecomment-645116392
**[Test build #124151 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124151/testReport)** for PR 28847 at commit [`c195a7f`](https://github.com/apache/spark/commit/c195a7fb321a646e2d016b173b51983c2bcda4c8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28847: [SPARK-29148][CORE][FOLLOWUP] Fix warning message to show a correct executor id
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28847:
URL: https://github.com/apache/spark/pull/28847#issuecomment-645168383
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28847: [SPARK-29148][CORE][FOLLOWUP] Fix warning message to show a correct executor id
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28847:
URL: https://github.com/apache/spark/pull/28847#issuecomment-645116392
**[Test build #124151 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124151/testReport)** for PR 28847 at commit [`c195a7f`](https://github.com/apache/spark/commit/c195a7fb321a646e2d016b173b51983c2bcda4c8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28847: [SPARK-29148][CORE][FOLLOWUP] Fix warning message to show a correct executor id
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28847:
URL: https://github.com/apache/spark/pull/28847#issuecomment-645168383
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28847: [SPARK-29148][CORE][FOLLOWUP] Fix warning message to show a correct executor id
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28847:
URL: https://github.com/apache/spark/pull/28847#issuecomment-645122517
Thank you, @HyukjinKwon .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28847: [SPARK-29148][CORE][FOLLOWUP] Fix warning message to show a correct executor id
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28847:
URL: https://github.com/apache/spark/pull/28847#issuecomment-645134832
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28847: [SPARK-29148][CORE][FOLLOWUP] Fix warning message to show a correct executor id
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28847:
URL: https://github.com/apache/spark/pull/28847#issuecomment-645114911
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org