[GitHub] bigtop pull request #111: BIGTOP-2357: Add Apache Flink to Bigtop / Create p...

[rvs <gi...@git.apache.org>]

Github user rvs commented on a diff in the pull request:

    https://github.com/apache/bigtop/pull/111#discussion_r67065894
  
    --- Diff: bigtop-deploy/puppet/modules/flink/manifests/init.pp ---
    @@ -0,0 +1,64 @@
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +class flink {
    +
    +  class deploy ($roles) {
    +    if ("flink-jobmanager" in $roles) {
    +      include flink::jobmanager
    +    }
    +
    +    if ("flink-taskmanager" in $roles) {
    +      include flink::taskmanager
    +    }
    +  }
    +
    +  class common($jobmanager_host, $jobmanager_port, $ui_port) {
    +    # make sure flink is installed
    +    package { "flink":
    +      ensure => latest
    +    }
    +
    +
    +    # set values in flink-conf.yaml
    +    $tmp_dirs = hadoop::hadoop_storage_dirs
    --- End diff --
    
    I'd be much more comfortable if this was passed in as a parameter from the outside of the puppet Flink class. Can you please do it that way?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---