You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2023/04/05 15:30:15 UTC
[kudu-CR](branch-1.17.x) [tools] update 'kudu table copy' CLI tool
Hello Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/19693
to review the following change.
Change subject: [tools] update 'kudu table copy' CLI tool
......................................................................
[tools] update 'kudu table copy' CLI tool
This patch adds 'insert_ignore' and 'upsert_ignore' write operations
for the 'kudu table copy' CLI tool. It also updates the implementation
of TableScanner::CopyTask() and TableScanner::AddRow() to perform less
string comparisons.
Change-Id: I8061f510710a30019db62627c91fb4caf4a13d27
Reviewed-on: http://gerrit.cloudera.org:8080/19595
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/table_scanner.h
3 files changed, 146 insertions(+), 59 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/19693/1
--
To view, visit http://gerrit.cloudera.org:8080/19693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8061f510710a30019db62627c91fb4caf4a13d27
Gerrit-Change-Number: 19693
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.17.x) [tools] update 'kudu table copy' CLI tool
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19693 )
Change subject: [tools] update 'kudu table copy' CLI tool
......................................................................
[tools] update 'kudu table copy' CLI tool
This patch adds 'insert_ignore' and 'upsert_ignore' write operations
for the 'kudu table copy' CLI tool. It also updates the implementation
of TableScanner::CopyTask() and TableScanner::AddRow() to perform less
string comparisons.
Change-Id: I8061f510710a30019db62627c91fb4caf4a13d27
Reviewed-on: http://gerrit.cloudera.org:8080/19595
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <la...@apache.org>
Reviewed-on: http://gerrit.cloudera.org:8080/19693
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/table_scanner.h
3 files changed, 146 insertions(+), 59 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I8061f510710a30019db62627c91fb4caf4a13d27
Gerrit-Change-Number: 19693
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.17.x) [tools] update 'kudu table copy' CLI tool
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19693 )
Change subject: [tools] update 'kudu table copy' CLI tool
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19693/1//COMMIT_MSG
Commit Message:
PS1:
Nit: in the future cherry-picks, please add '-x' option when cherry picking changes, i.e. run 'git cherry-pick -x <commit_uuid>'. That's to add an UUID of the original commit into the message, so it's easier to look it up in the history. Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/19693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8061f510710a30019db62627c91fb4caf4a13d27
Gerrit-Change-Number: 19693
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 05 Apr 2023 16:32:35 +0000
Gerrit-HasComments: Yes