You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/22 18:24:46 UTC
[GitHub] [druid] zachjsh commented on a diff in pull request #13089: Add JsonInputFormat option to assume newline delimited JSON, improve parse exception handling for multiline JSON
zachjsh commented on code in PR #13089:
URL: https://github.com/apache/druid/pull/13089#discussion_r977963559
##########
core/src/main/java/org/apache/druid/data/input/impl/JsonInputFormat.java:
##########
@@ -85,6 +106,8 @@ public JsonInputFormat(
objectMapper.configure(feature, entry.getValue());
}
this.lineSplittable = lineSplittable;
+ this.assumeNewlineDelimited = assumeNewlineDelimited != null && assumeNewlineDelimited;
+ this.useJsonNodeReader = useJsonNodeReader != null && useJsonNodeReader;
Review Comment:
The description for this property above seems to indicate that it should be used for non-newline delimited JSON. Would `assumeNewLineDelimted` true interfere with this / should this be forced to false if `assumeNewLineDelimted` is true
##########
core/src/main/java/org/apache/druid/data/input/impl/JsonInputFormat.java:
##########
@@ -85,6 +106,8 @@ public JsonInputFormat(
objectMapper.configure(feature, entry.getValue());
}
this.lineSplittable = lineSplittable;
+ this.assumeNewlineDelimited = assumeNewlineDelimited != null && assumeNewlineDelimited;
+ this.useJsonNodeReader = useJsonNodeReader != null && useJsonNodeReader;
Review Comment:
The description for this property above seems to indicate that it should be used for non-newline delimited JSON. Would `assumeNewLineDelimted` true interfere with this / should this be forced to false if `assumeNewLineDelimted` is true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org