[jira] Commented: (CHUKWA-4) Collectors don't finish writing .done datasink from last .chukwa datasink when stopped using bin/stop-collectors

["Ari Rabkin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CHUKWA-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863506#action_12863506 ] 

Ari Rabkin commented on CHUKWA-4:
---------------------------------

OK.  Finally had a chance to review this.  Looks good, and sorry for the delay -- crazy busy at my end.  
- Can you say a bit about how you tested it?  
- I also don't quite understand when it gets invoked. Just from the localToHDFSMover?  That would mean that the default configuration of "writers writing directly to HDFS" won't be affected. That's OK for now, but we should open a new issue to ultimately remove that limitation.



--Ari

> Collectors don't finish writing .done datasink from last .chukwa datasink when stopped using bin/stop-collectors
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: CHUKWA-4
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-4
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>          Components: data collection
>         Environment: I am running on our local cluster. This is a linux machine that I also run Hadoop cluster from.
>            Reporter: Andy Konwinski
>            Priority: Minor
>         Attachments: CHUKWA-4.2.patch, CHUKWA-4.patch
>
>
> When I use start-collectors, it creates the datasink as expected, writes to it as per normal, i.e. writes to the .chukwa file, and roll overs work fine when it renames the .chukwa file to .done. However, when I use bin/stop-collectors to shut down the running collector it leaves a .chukwa file in the HDFS file system. Not sure if this is a valid sink or not, but I think that the collector should gracefully clean up the datasink and rename it .done before exiting.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.