[GitHub] [activemq-artemis] jbertram commented on a diff in pull request #4340: ARTEMIS-4137 MQTT sub-queue clean-up can fail due to auth

["jbertram (via GitHub)" <gi...@apache.org>]

jbertram commented on code in PR #4340:
URL: https://github.com/apache/activemq-artemis/pull/4340#discussion_r1173919192


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java:
##########
@@ -1178,7 +1183,7 @@ public void deleteQueue(final SimpleString queueToDelete) throws Exception {
          throw new ActiveMQNonExistentQueueException();
       }
 
-      server.destroyQueue(unPrefixedQueueName, this, true, false, true);
+      server.destroyQueue(unPrefixedQueueName, enforceSecurity ? this : null, true, false, true);

Review Comment:
   If `enforceSecurity` is `true` then `this` is passed and security will be enforced. Otherwise `null` is passed and security is not enforced. Previously security was always enforced which would prevent the broker from cleaning up the subscription queue in certain situations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org