You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/30 06:50:53 UTC

[GitHub] [pulsar] casuallc opened a new pull request #12249: Fix time field use error

casuallc opened a new pull request #12249:
URL: https://github.com/apache/pulsar/pull/12249


   Should check the field eventTime but not publishTime.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] casuallc removed a comment on pull request #12249: Fix time field use error

Posted by GitBox <gi...@apache.org>.
casuallc removed a comment on pull request #12249:
URL: https://github.com/apache/pulsar/pull/12249#issuecomment-976374456


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] casuallc commented on pull request #12249: Fix time field use error

Posted by GitBox <gi...@apache.org>.
casuallc commented on pull request #12249:
URL: https://github.com/apache/pulsar/pull/12249#issuecomment-965951820


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] casuallc commented on pull request #12249: Fix time field use error

Posted by GitBox <gi...@apache.org>.
casuallc commented on pull request #12249:
URL: https://github.com/apache/pulsar/pull/12249#issuecomment-976374456


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj merged pull request #12249: Fix time field use error

Posted by GitBox <gi...@apache.org>.
Shoothzj merged pull request #12249:
URL: https://github.com/apache/pulsar/pull/12249


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] hangc0276 commented on pull request #12249: Fix time field use error

Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #12249:
URL: https://github.com/apache/pulsar/pull/12249#issuecomment-976676851


   /pulsarbot run-failure-checks
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] hangc0276 closed pull request #12249: Fix time field use error

Posted by GitBox <gi...@apache.org>.
hangc0276 closed pull request #12249:
URL: https://github.com/apache/pulsar/pull/12249


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tomscut commented on pull request #12249: Fix time field use error

Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #12249:
URL: https://github.com/apache/pulsar/pull/12249#issuecomment-944227969


   Hi @hangc0276 @codelipenghui, could you please help review this PR? Since ```First-time contributors need a maintainer to approve running workflows.```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] casuallc commented on pull request #12249: Fix time field use error

Posted by GitBox <gi...@apache.org>.
casuallc commented on pull request #12249:
URL: https://github.com/apache/pulsar/pull/12249#issuecomment-931004453


   > Thanks for your contribution. For this PR, do we need to update docs?
   > 
   > (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
   
   No need.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #12249: Fix time field use error

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #12249:
URL: https://github.com/apache/pulsar/pull/12249#issuecomment-930929400


   Thanks for your contribution. For this PR, do we need to update docs?
   
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] casuallc commented on pull request #12249: Fix time field use error

Posted by GitBox <gi...@apache.org>.
casuallc commented on pull request #12249:
URL: https://github.com/apache/pulsar/pull/12249#issuecomment-931014341


   I am confused with the failed tests.
   
   There is some reason for use the field publishTime?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] casuallc removed a comment on pull request #12249: Fix time field use error

Posted by GitBox <gi...@apache.org>.
casuallc removed a comment on pull request #12249:
URL: https://github.com/apache/pulsar/pull/12249#issuecomment-965951820


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org