You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Justin Mclean <ju...@classsoftware.com> on 2017/06/25 11:13:49 UTC
Re: flex-asjs git commit: DisableBead should not access the strand until it’s added
Hi,
I’m curious and certainly not a veto / asking you to revert this.
Is there any reason why this isn’t a BailoutDisableBead via PAYG concepts?
Thanks,
Justin
> On 25 Jun 2017, at 7:36 pm, harbs@apache.org wrote:
>
> Repository: flex-asjs
> Updated Branches:
> refs/heads/tlf 26b15e5a0 -> 99864a8cd
>
>
> DisableBead should not access the strand until it’s added
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/99864a8c
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/99864a8c
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/99864a8c
>
> Branch: refs/heads/tlf
> Commit: 99864a8cd3605a5030adbec67083f7de7865462b
> Parents: 26b15e5
> Author: Harbs <ha...@in-tools.com>
> Authored: Sun Jun 25 12:36:47 2017 +0300
> Committer: Harbs <ha...@in-tools.com>
> Committed: Sun Jun 25 12:36:47 2017 +0300
>
> ----------------------------------------------------------------------
> .../Basic/src/main/flex/org/apache/flex/html/beads/DisableBead.as | 2 ++
> 1 file changed, 2 insertions(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/99864a8c/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/DisableBead.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/DisableBead.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/DisableBead.as
> index 1d17477..2f8da88 100644
> --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/DisableBead.as
> +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/DisableBead.as
> @@ -106,6 +106,8 @@ package org.apache.flex.html.beads
>
> private function updateHost():void
> {
> + if(!_strand)//bail out
> + return;
> COMPILE::SWF {
> var interactiveObject:InteractiveObject = _strand as InteractiveObject;
> interactiveObject.mouseEnabled = !disabled;
>
Re: flex-asjs git commit: DisableBead should not access the strand until it’s added
Posted by piotrz <pi...@gmail.com>.
WOW! Great news :) Looking forward to that. !
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-flex-asjs-git-commit-DisableBead-should-not-access-the-strand-until-it-s-added-tp62602p62606.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: flex-asjs git commit: DisableBead should not access the strand until it’s added
Posted by Harbs <ha...@gmail.com>.
I’m actually thinking of merging TLF back sometime over the next few weeks.
I’m at the point where TLF is working pretty well…
If there’s specific commits that someone wants before then, I’ll be happy to help with cherry picking.
> On Jun 25, 2017, at 3:14 PM, piotrz <pi...@gmail.com> wrote:
>
> Harbs,
>
> Your TLF branch will not be soon merged, can you more important fixes from
> time to time make also to develop ?
>
> Thanks,
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-flex-asjs-git-commit-DisableBead-should-not-access-the-strand-until-it-s-added-tp62602p62604.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: flex-asjs git commit: DisableBead should not access the strand until it’s added
Posted by piotrz <pi...@gmail.com>.
Harbs,
Your TLF branch will not be soon merged, can you more important fixes from
time to time make also to develop ?
Thanks,
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-flex-asjs-git-commit-DisableBead-should-not-access-the-strand-until-it-s-added-tp62602p62604.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: flex-asjs git commit: DisableBead should not access the strand until it’s added
Posted by Harbs <ha...@gmail.com>.
Sure.
The bug was that specifying the initial disabled value in MXML caused a runtime error:
<js:DisableBead id="disableBead" disabled="true”/>
The MXML is evaluated before the strand is set, so updateHost() needs to be delayed until it is set.
> On Jun 25, 2017, at 2:13 PM, Justin Mclean <ju...@classsoftware.com> wrote:
>
> Hi,
>
> I’m curious and certainly not a veto / asking you to revert this.
>
> Is there any reason why this isn’t a BailoutDisableBead via PAYG concepts?
>
> Thanks,
> Justin
>
>> On 25 Jun 2017, at 7:36 pm, harbs@apache.org wrote:
>>
>> Repository: flex-asjs
>> Updated Branches:
>> refs/heads/tlf 26b15e5a0 -> 99864a8cd
>>
>>
>> DisableBead should not access the strand until it’s added
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/99864a8c
>> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/99864a8c
>> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/99864a8c
>>
>> Branch: refs/heads/tlf
>> Commit: 99864a8cd3605a5030adbec67083f7de7865462b
>> Parents: 26b15e5
>> Author: Harbs <ha...@in-tools.com>
>> Authored: Sun Jun 25 12:36:47 2017 +0300
>> Committer: Harbs <ha...@in-tools.com>
>> Committed: Sun Jun 25 12:36:47 2017 +0300
>>
>> ----------------------------------------------------------------------
>> .../Basic/src/main/flex/org/apache/flex/html/beads/DisableBead.as | 2 ++
>> 1 file changed, 2 insertions(+)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/99864a8c/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/DisableBead.as
>> ----------------------------------------------------------------------
>> diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/DisableBead.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/DisableBead.as
>> index 1d17477..2f8da88 100644
>> --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/DisableBead.as
>> +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/DisableBead.as
>> @@ -106,6 +106,8 @@ package org.apache.flex.html.beads
>>
>> private function updateHost():void
>> {
>> + if(!_strand)//bail out
>> + return;
>> COMPILE::SWF {
>> var interactiveObject:InteractiveObject = _strand as InteractiveObject;
>> interactiveObject.mouseEnabled = !disabled;
>>
>