You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by András Piros via Review Board <no...@reviews.apache.org> on 2018/11/30 12:49:11 UTC
Review Request 69492: OOZIE-3389 Getting input dependency list on the
UI throws NPE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69492/
-----------------------------------------------------------
Review request for oozie, Andras Salamon and Kinga Marton.
Repository: oozie-git
Description
-------
OOZIE-3389 Getting input dependency list on the UI throws NPE
Diffs
-----
core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java d37cfe5125a5c3a665b3e33e6ac3fd5581fe278f
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java 56aef1c1779ed7446852af42f25c5ca058e473e4
core/src/test/java/org/apache/oozie/coord/input/dependency/TestCoordOldInputDependency.java PRE-CREATION
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java bacfe89bb3d836da1f6e559fa68a5bf4db970b09
Diff: https://reviews.apache.org/r/69492/diff/1/
Testing
-------
Introduced new unit test class `TestCoordOldInputDependency`.
Thanks,
András Piros
Re: Review Request 69492: OOZIE-3389 Getting input dependency list on
the UI throws NPE
Posted by Kinga Marton via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69492/#review210999
-----------------------------------------------------------
Ship it!
Ship It!
- Kinga Marton
On Dec. 1, 2018, 2:21 p.m., András Piros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69492/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2018, 2:21 p.m.)
>
>
> Review request for oozie, Andras Salamon and Kinga Marton.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3389 Getting input dependency list on the UI throws NPE
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java d37cfe5125a5c3a665b3e33e6ac3fd5581fe278f
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java 56aef1c1779ed7446852af42f25c5ca058e473e4
> core/src/test/java/org/apache/oozie/coord/input/dependency/TestCoordOldInputDependency.java PRE-CREATION
> core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java bacfe89bb3d836da1f6e559fa68a5bf4db970b09
>
>
> Diff: https://reviews.apache.org/r/69492/diff/2/
>
>
> Testing
> -------
>
> Introduced new unit test class `TestCoordOldInputDependency`.
>
>
> Thanks,
>
> András Piros
>
>
Re: Review Request 69492: OOZIE-3389 Getting input dependency list on
the UI throws NPE
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69492/
-----------------------------------------------------------
(Updated Dec. 1, 2018, 2:21 p.m.)
Review request for oozie, Andras Salamon and Kinga Marton.
Changes
-------
Addressing review comments.
Repository: oozie-git
Description
-------
OOZIE-3389 Getting input dependency list on the UI throws NPE
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java d37cfe5125a5c3a665b3e33e6ac3fd5581fe278f
core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java 56aef1c1779ed7446852af42f25c5ca058e473e4
core/src/test/java/org/apache/oozie/coord/input/dependency/TestCoordOldInputDependency.java PRE-CREATION
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java bacfe89bb3d836da1f6e559fa68a5bf4db970b09
Diff: https://reviews.apache.org/r/69492/diff/2/
Changes: https://reviews.apache.org/r/69492/diff/1-2/
Testing
-------
Introduced new unit test class `TestCoordOldInputDependency`.
Thanks,
András Piros
Re: Review Request 69492: OOZIE-3389 Getting input dependency list on
the UI throws NPE
Posted by András Piros via Review Board <no...@reviews.apache.org>.
> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Line 121 (original), 120 (patched)
> > <https://reviews.apache.org/r/69492/diff/1/?file=2111274#file2111274line121>
> >
> > Could you please add assert message.
It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in a separate JIRA.
> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Lines 127 (patched)
> > <https://reviews.apache.org/r/69492/diff/1/?file=2111274#file2111274line128>
> >
> > Could you please assertMessage
Done.
> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Lines 179-184 (original), 183-188 (patched)
> > <https://reviews.apache.org/r/69492/diff/1/?file=2111274#file2111274line184>
> >
> > This code (PUT) appears multiple times. Could you extract it to a method?
It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in a separate JIRA.
> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Line 184 (original), 188 (patched)
> > <https://reviews.apache.org/r/69492/diff/1/?file=2111274#file2111274line189>
> >
> > Could you please add assert message.
It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in a separate JIRA.
> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Lines 218-223 (original), 222-227 (patched)
> > <https://reviews.apache.org/r/69492/diff/1/?file=2111274#file2111274line223>
> >
> > This code (PUT) appears multiple times. Could you extract it to a method?
It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in a separate JIRA.
> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Line 223 (original), 227 (patched)
> > <https://reviews.apache.org/r/69492/diff/1/?file=2111274#file2111274line228>
> >
> > Could you please add assert message.
It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in a separate JIRA.
> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Lines 313-316 (original), 317-320 (patched)
> > <https://reviews.apache.org/r/69492/diff/1/?file=2111274#file2111274line318>
> >
> > This code (GET) appears multiple times. Could you extract it to a method?
It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in a separate JIRA.
> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Lines 334-337 (original), 338-341 (patched)
> > <https://reviews.apache.org/r/69492/diff/1/?file=2111274#file2111274line339>
> >
> > This code (GET) appears multiple times. Could you extract it to a method?
It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in a separate JIRA.
> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Lines 355-358 (original), 359-362 (patched)
> > <https://reviews.apache.org/r/69492/diff/1/?file=2111274#file2111274line360>
> >
> > This code (GET) appears multiple times. Could you extract it to a method?
It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in a separate JIRA.
> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Lines 419-422 (original), 423-426 (patched)
> > <https://reviews.apache.org/r/69492/diff/1/?file=2111274#file2111274line424>
> >
> > This code (GET) appears multiple times. Could you extract it to a method?
It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in a separate JIRA.
> On Nov. 30, 2018, 1:01 p.m., Andras Salamon wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Lines 440-443 (original), 444-447 (patched)
> > <https://reviews.apache.org/r/69492/diff/1/?file=2111274#file2111274line445>
> >
> > This code (GET) appears multiple times. Could you extract it to a method?
It's not part of the changed code. `TestV2JobServlet` deserves refactoring - in a separate JIRA.
- András
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69492/#review210973
-----------------------------------------------------------
On Nov. 30, 2018, 12:49 p.m., András Piros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69492/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2018, 12:49 p.m.)
>
>
> Review request for oozie, Andras Salamon and Kinga Marton.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3389 Getting input dependency list on the UI throws NPE
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java d37cfe5125a5c3a665b3e33e6ac3fd5581fe278f
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java 56aef1c1779ed7446852af42f25c5ca058e473e4
> core/src/test/java/org/apache/oozie/coord/input/dependency/TestCoordOldInputDependency.java PRE-CREATION
> core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java bacfe89bb3d836da1f6e559fa68a5bf4db970b09
>
>
> Diff: https://reviews.apache.org/r/69492/diff/1/
>
>
> Testing
> -------
>
> Introduced new unit test class `TestCoordOldInputDependency`.
>
>
> Thanks,
>
> András Piros
>
>
Re: Review Request 69492: OOZIE-3389 Getting input dependency list on
the UI throws NPE
Posted by Andras Salamon <an...@melda.info>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69492/#review210973
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java
Line 121 (original), 121 (patched)
<https://reviews.apache.org/r/69492/#comment295794>
!isEmpty() might be nicer
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Line 121 (original), 120 (patched)
<https://reviews.apache.org/r/69492/#comment295803>
Could you please add assert message.
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Lines 127 (patched)
<https://reviews.apache.org/r/69492/#comment295795>
Could you please assertMessage
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Lines 179-184 (original), 183-188 (patched)
<https://reviews.apache.org/r/69492/#comment295796>
This code (PUT) appears multiple times. Could you extract it to a method?
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Line 184 (original), 188 (patched)
<https://reviews.apache.org/r/69492/#comment295804>
Could you please add assert message.
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Lines 218-223 (original), 222-227 (patched)
<https://reviews.apache.org/r/69492/#comment295797>
This code (PUT) appears multiple times. Could you extract it to a method?
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Line 223 (original), 227 (patched)
<https://reviews.apache.org/r/69492/#comment295805>
Could you please add assert message.
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Lines 313-316 (original), 317-320 (patched)
<https://reviews.apache.org/r/69492/#comment295798>
This code (GET) appears multiple times. Could you extract it to a method?
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Lines 334-337 (original), 338-341 (patched)
<https://reviews.apache.org/r/69492/#comment295799>
This code (GET) appears multiple times. Could you extract it to a method?
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Lines 355-358 (original), 359-362 (patched)
<https://reviews.apache.org/r/69492/#comment295800>
This code (GET) appears multiple times. Could you extract it to a method?
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Lines 419-422 (original), 423-426 (patched)
<https://reviews.apache.org/r/69492/#comment295801>
This code (GET) appears multiple times. Could you extract it to a method?
core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
Lines 440-443 (original), 444-447 (patched)
<https://reviews.apache.org/r/69492/#comment295802>
This code (GET) appears multiple times. Could you extract it to a method?
- Andras Salamon
On Nov. 30, 2018, 12:49 p.m., András Piros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69492/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2018, 12:49 p.m.)
>
>
> Review request for oozie, Andras Salamon and Kinga Marton.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3389 Getting input dependency list on the UI throws NPE
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java d37cfe5125a5c3a665b3e33e6ac3fd5581fe278f
> core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java 56aef1c1779ed7446852af42f25c5ca058e473e4
> core/src/test/java/org/apache/oozie/coord/input/dependency/TestCoordOldInputDependency.java PRE-CREATION
> core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java bacfe89bb3d836da1f6e559fa68a5bf4db970b09
>
>
> Diff: https://reviews.apache.org/r/69492/diff/1/
>
>
> Testing
> -------
>
> Introduced new unit test class `TestCoordOldInputDependency`.
>
>
> Thanks,
>
> András Piros
>
>