[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #24446: Add test cases for ImportDatabaseConfigurationUpdater.

["RaigorJiang (via GitHub)" <gi...@apache.org>]

RaigorJiang commented on code in PR #24446:
URL: https://github.com/apache/shardingsphere/pull/24446#discussion_r1125223029


##########
proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/ImportDatabaseConfigurationUpdater.java:
##########
@@ -33,6 +33,8 @@
  */
 public final class ImportDatabaseConfigurationUpdater implements RALUpdater<ImportDatabaseConfigurationStatement> {
     
+    private final YamlDatabaseConfigurationImportExecutor databaseConfigImportExecutor = new YamlDatabaseConfigurationImportExecutor();

Review Comment:
   No other function uses databaseConfigImportExecutor , can it be a local variable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org