You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2018/09/07 00:38:00 UTC
[jira] [Commented] (ZOOKEEPER-3124) Add the correct comment to show
why we need the special logic to handle cversion and pzxid
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606573#comment-16606573 ]
Hadoop QA commented on ZOOKEEPER-3124:
--------------------------------------
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2131//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2131//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2131//console
This message is automatically generated.
> Add the correct comment to show why we need the special logic to handle cversion and pzxid
> ------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-3124
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3124
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Reporter: Fangmin Lv
> Assignee: Fangmin Lv
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The old comment about setCversionPzxid is not valid, the scenario it mentioned won't trigger the issue, update it to show the exact reason.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)