You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/11/18 02:23:08 UTC
[GitHub] [zeppelin] zjffdu opened a new pull request #3974: [ZEPPELIN-5135]. Keep default.splitQueries in jdbc
zjffdu opened a new pull request #3974:
URL: https://github.com/apache/zeppelin/pull/3974
### What is this PR for?
This PR is to bring back `default.splitQueries` in jdbc, so that user can choose whether split sql. But by default, we still enable it.
### What type of PR is it?
[Improvement ]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5135
### How should this be tested?
* CI pass
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a change in pull request #3974: [ZEPPELIN-5135]. Keep default.splitQueries in jdbc
Posted by GitBox <gi...@apache.org>.
Reamer commented on a change in pull request #3974:
URL: https://github.com/apache/zeppelin/pull/3974#discussion_r525876164
##########
File path: jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java
##########
@@ -19,6 +19,7 @@
import static org.apache.commons.lang3.StringUtils.isNotEmpty;
import static org.apache.hadoop.security.UserGroupInformation.AuthenticationMethod.KERBEROS;
+import com.beust.jcommander.internal.Lists;
Review comment:
wrong import?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3974: [ZEPPELIN-5135]. Keep default.splitQueries in jdbc
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #3974:
URL: https://github.com/apache/zeppelin/pull/3974#discussion_r525915319
##########
File path: jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java
##########
@@ -19,6 +19,7 @@
import static org.apache.commons.lang3.StringUtils.isNotEmpty;
import static org.apache.hadoop.security.UserGroupInformation.AuthenticationMethod.KERBEROS;
+import com.beust.jcommander.internal.Lists;
Review comment:
Thanks, fixed now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #3974: [ZEPPELIN-5135]. Keep default.splitQueries in jdbc
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3974:
URL: https://github.com/apache/zeppelin/pull/3974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org