You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Liviu Tudor (JIRA)" <ji...@apache.org> on 2012/07/30 22:35:35 UTC
[jira] [Created] (POOL-224) findbugs performance warnings on
StackKeyedObjectPool
Liviu Tudor created POOL-224:
--------------------------------
Summary: findbugs performance warnings on StackKeyedObjectPool
Key: POOL-224
URL: https://issues.apache.org/jira/browse/POOL-224
Project: Commons Pool
Issue Type: Improvement
Affects Versions: 1.6
Reporter: Liviu Tudor
Priority: Trivial
Fix For: 1.6.1
Findbugs is currently showing 2 performance warnings in {{StackKeyedObjectPool}} due to the usage of
{code:java}new Integer(value){code}
as opposed to
{code:java}Integer.valueOf(value){code}
Also, it seems we create a new {{Integer}} instance each time we need to store 1 in the map -- since the {{Integer}} class is immutable, we can actually share one single instance for these cases, and reduce pressure on the GC, and this patch addresses this minor optimization as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (POOL-224) findbugs performance warnings on
StackKeyedObjectPool
Posted by "Liviu Tudor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/POOL-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liviu Tudor updated POOL-224:
-----------------------------
Attachment: POOL-224.patch.bz2
fix for this issue and also some formatting changes.
> findbugs performance warnings on StackKeyedObjectPool
> -----------------------------------------------------
>
> Key: POOL-224
> URL: https://issues.apache.org/jira/browse/POOL-224
> Project: Commons Pool
> Issue Type: Improvement
> Affects Versions: 1.6
> Reporter: Liviu Tudor
> Priority: Trivial
> Labels: findbugs
> Fix For: 1.6.1
>
> Attachments: POOL-224.patch.bz2
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> Findbugs is currently showing 2 performance warnings in {{StackKeyedObjectPool}} due to the usage of
> {code:java}new Integer(value){code}
> as opposed to
> {code:java}Integer.valueOf(value){code}
> Also, it seems we create a new {{Integer}} instance each time we need to store 1 in the map -- since the {{Integer}} class is immutable, we can actually share one single instance for these cases, and reduce pressure on the GC, and this patch addresses this minor optimization as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (POOL-224) FindBugs performance warnings on
StackKeyedObjectPool
Posted by "Gary D. Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/POOL-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary D. Gregory resolved POOL-224.
----------------------------------
Resolution: Fixed
commit -m "[POOL-224] FindBugs performance warnings on StackKeyedObjectPool." C:/svn/org/apache/commons/branches/pool-1.x/src/changes/changes.xml C:/svn/org/apache/commons/branches/pool-1.x/src/java/org/apache/commons/pool/impl/StackKeyedObjectPool.java
Sending C:/svn/org/apache/commons/branches/pool-1.x/src/changes/changes.xml
Sending C:/svn/org/apache/commons/branches/pool-1.x/src/java/org/apache/commons/pool/impl/StackKeyedObjectPool.java
Transmitting file data ...
Committed revision 1367304.
> FindBugs performance warnings on StackKeyedObjectPool
> -----------------------------------------------------
>
> Key: POOL-224
> URL: https://issues.apache.org/jira/browse/POOL-224
> Project: Commons Pool
> Issue Type: Improvement
> Affects Versions: 1.6
> Reporter: Liviu Tudor
> Priority: Trivial
> Labels: findbugs
> Fix For: 1.6.1
>
> Attachments: POOL-224.patch.bz2
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> FindBugs is currently showing 2 performance warnings in {{StackKeyedObjectPool}} due to the usage of
> {code:java}new Integer(value){code}
> as opposed to
> {code:java}Integer.valueOf(value){code}
> Also, it seems we create a new {{Integer}} instance each time we need to store 1 in the map -- since the {{Integer}} class is immutable, we can actually share one single instance for these cases, and reduce pressure on the GC, and this patch addresses this minor optimization as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (POOL-224) FindBugs performance warnings on
StackKeyedObjectPool
Posted by "Gary D. Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/POOL-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary D. Gregory updated POOL-224:
---------------------------------
Description:
FindBugs is currently showing 2 performance warnings in {{StackKeyedObjectPool}} due to the usage of
{code:java}new Integer(value){code}
as opposed to
{code:java}Integer.valueOf(value){code}
Also, it seems we create a new {{Integer}} instance each time we need to store 1 in the map -- since the {{Integer}} class is immutable, we can actually share one single instance for these cases, and reduce pressure on the GC, and this patch addresses this minor optimization as well.
was:
Findbugs is currently showing 2 performance warnings in {{StackKeyedObjectPool}} due to the usage of
{code:java}new Integer(value){code}
as opposed to
{code:java}Integer.valueOf(value){code}
Also, it seems we create a new {{Integer}} instance each time we need to store 1 in the map -- since the {{Integer}} class is immutable, we can actually share one single instance for these cases, and reduce pressure on the GC, and this patch addresses this minor optimization as well.
Summary: FindBugs performance warnings on StackKeyedObjectPool (was: findbugs performance warnings on StackKeyedObjectPool)
Fix typos in the ticket.
> FindBugs performance warnings on StackKeyedObjectPool
> -----------------------------------------------------
>
> Key: POOL-224
> URL: https://issues.apache.org/jira/browse/POOL-224
> Project: Commons Pool
> Issue Type: Improvement
> Affects Versions: 1.6
> Reporter: Liviu Tudor
> Priority: Trivial
> Labels: findbugs
> Fix For: 1.6.1
>
> Attachments: POOL-224.patch.bz2
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> FindBugs is currently showing 2 performance warnings in {{StackKeyedObjectPool}} due to the usage of
> {code:java}new Integer(value){code}
> as opposed to
> {code:java}Integer.valueOf(value){code}
> Also, it seems we create a new {{Integer}} instance each time we need to store 1 in the map -- since the {{Integer}} class is immutable, we can actually share one single instance for these cases, and reduce pressure on the GC, and this patch addresses this minor optimization as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira