You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by ka...@apache.org on 2023/10/31 03:32:02 UTC
(spark) branch master updated: [SPARK-45727][SS] Remove unused map in watermark propagation simulation
This is an automated email from the ASF dual-hosted git repository.
kabhwan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new fc6a5cca06c [SPARK-45727][SS] Remove unused map in watermark propagation simulation
fc6a5cca06c is described below
commit fc6a5cca06cf15c4a952cb56720f627efdba7cce
Author: Anish Shrigondekar <an...@databricks.com>
AuthorDate: Tue Oct 31 12:31:48 2023 +0900
[SPARK-45727][SS] Remove unused map in watermark propagation simulation
### What changes were proposed in this pull request?
Remove unused map in watermark propagation simulation
### Why are the changes needed?
Remove use of redundant/unused map
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing unit tests
```
===== POSSIBLE THREAD LEAK IN SUITE o.a.s.sql.streaming.MultiStatefulOperatorsSuite, threads: rpc-boss-3-1 (daemon=true), ForkJoinPool.commonPool-worker-2 (daemon=true), shuffle-boss-6-1 (daemon=true), ForkJoinPool.commonPool-worker-1 (daemon=true) =====
[info] Run completed in 1 minute, 35 seconds.
[info] Total number of tests run: 9
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 9, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
```
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #43588 from anishshri-db/task/SPARK-45727.
Authored-by: Anish Shrigondekar <an...@databricks.com>
Signed-off-by: Jungtaek Lim <ka...@gmail.com>
---
.../org/apache/spark/sql/execution/streaming/WatermarkPropagator.scala | 2 --
1 file changed, 2 deletions(-)
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/WatermarkPropagator.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/WatermarkPropagator.scala
index 6f3725bebb9..a4bee7e95b4 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/WatermarkPropagator.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/WatermarkPropagator.scala
@@ -181,7 +181,6 @@ class PropagateWatermarkSimulator extends WatermarkPropagator with Logging {
}
private def doSimulate(batchId: Long, plan: SparkPlan, originWatermark: Long): Unit = {
- val statefulOperatorIdToNodeId = mutable.HashMap[Long, Int]()
val nodeToOutputWatermark = mutable.HashMap[Int, Option[Long]]()
val nextStatefulOperatorToWatermark = mutable.HashMap[Long, Option[Long]]()
@@ -200,7 +199,6 @@ class PropagateWatermarkSimulator extends WatermarkPropagator with Logging {
case node: StateStoreWriter =>
val stOpId = node.stateInfo.get.operatorId
- statefulOperatorIdToNodeId.put(stOpId, node.id)
val inputWatermarks = getInputWatermarks(node, nodeToOutputWatermark)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org