[jira] Commented: (SOLR-143) Support for PMD and Clover

["Paul Sundling (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519525 ] 

Paul Sundling commented on SOLR-143:
------------------------------------

It would be trivial to integrate PMD and clover if you add a maven build.  There are already plugins and I've used them successfully myself.  They run during "site" generation which generates reports, although they can also be used to fail a build if desired.

The eclipse plugin for PMD is great, because it includes links to the detailed description on why the issues are a bad practice.  There were a few links missing, but I added a patch to add the missing links.  However there is a bug in the eclipse plugin where the links stop working if you export the ruleset. (http://sourceforge.net/tracker/index.php?func=detail&aid=1745607&group_id=132036&atid=723729) 

> Support for PMD and Clover
> --------------------------
>
>                 Key: SOLR-143
>                 URL: https://issues.apache.org/jira/browse/SOLR-143
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>            Priority: Minor
>         Attachments: pmd-and-clover.diff, SOLR-143-CloverAndPMD.patch
>
>
> had some time on a plane this weekend, so I adapted some of the clover hooks from Java-Lucene to Solr's build.xml and also put in hooks for running PMD (a bug pattern finding tool).
> the PMD hook actually teste the PMD ruleset twice, once warning about any violations, and once failing the build if any serious violations were found ... the goal would be to hook this into the "ant test" target so you can't successfully build if you have any serious rule violations.
> i strarted with a custom ruleset based on some of the bigger rules from PMD ... the theory being that as well clean up the code base we can add more nit-picky rules if we want to :)
> User is required to provide their own copy of PMD and/or clover on in an ANT_LIB. Clover requires (ASF committer) license, PMD is freely available...
> http://pmd.sourceforge.net/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.