[GitHub] [spark] turboFei edited a comment on pull request #29982: [SPARK-33100][SQL] Ignore a semicolon inside a bracketed comment in spark-sql

[GitBox <gi...@apache.org>]

turboFei edited a comment on pull request #29982:
URL: https://github.com/apache/spark/pull/29982#issuecomment-707801924


   thanks for your comments @maropu @yaooqinn 
   I tried to thought how to remove the variable `bracketedCommentRightBound` but could not find a better way to recognize bracketed comment.
   
   Without this variable:
   1. I might need leave the bracketed comment when current char equals '/' and last char equals '*', but it is difficult to judge whether the statement begin.
   2. If I do not leave the bracketed comment when current char equals '/' and last char equals '*', it is difficult to leave the comment later.
   For example:
   the line likes: select */*comment\*/ from ta;
   
   So, I recommend to save this variable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org