You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by Ethanlm <gi...@git.apache.org> on 2017/07/17 19:07:01 UTC

[GitHub] storm pull request #2219: [STORM-2637] fix ClassCastException in logviewer g...

GitHub user Ethanlm opened a pull request:

    https://github.com/apache/storm/pull/2219

    [STORM-2637] fix ClassCastException in logviewer get-log-user-group-whitelist func…

    In get-log-user-group-whitelist function, the getLogMetaDataFile function returns a File while the readYamlFile function requires a String.
    
    see https://issues.apache.org/jira/browse/STORM-2637

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Ethanlm/storm STORM-2637

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2219.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2219
    
----
commit f636fdbab9aec58bc27da3b5b8c7a1110266c05a
Author: Ethan Li <et...@gmail.com>
Date:   2017-07-17T19:02:21Z

    fix ClassCastException in logviewer get-log-user-group-whitelist function

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2219: [STORM-2637] fix ClassCastException in logviewer g...

Posted by Ethanlm <gi...@git.apache.org>.

Github user Ethanlm closed the pull request at:

    https://github.com/apache/storm/pull/2219


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2219: [STORM-2637] fix ClassCastException in logviewer g...

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2219#discussion_r127842992
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/logviewer.clj ---
    @@ -311,7 +311,7 @@
     
     (defn get-log-user-group-whitelist [fname]
       (let [wl-file (ServerConfigUtils/getLogMetaDataFile fname)
    -        m (clojurify-structure (Utils/readYamlFile wl-file))]
    +        m (clojurify-structure (Utils/readYamlFile (.toString wl-file)))]
    --- End diff --
    
    Maybe better to use `getAbsolutePath` or `getCanonicalPath` to clearly represent path. I used `getAbsolutePath` from #2204 but I can change it if others claim that `getCanonicalPath` is more preferred.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2219: [STORM-2637] fix ClassCastException in logviewer get-log-...

Posted by Ethanlm <gi...@git.apache.org>.

Github user Ethanlm commented on the issue:

    https://github.com/apache/storm/pull/2219
  
    Close this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2219: [STORM-2637] fix ClassCastException in logviewer get-log-...

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2219
  
    Thanks for the patch. I just would like to see this patch against 1.x branch rather than master, given that we should review and apply #2204 to remove Clojure implementation. 
    Btw, if you had (or have) a chance to read logviewer clojure implementation, I would like to ask a favor with reviewing #2204.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2219: [STORM-2637] fix ClassCastException in logviewer get-log-...

Posted by Ethanlm <gi...@git.apache.org>.

Github user Ethanlm commented on the issue:

    https://github.com/apache/storm/pull/2219
  
    Thanks. I will submit a patch against 1.x branch.  I am not very familiar with logviewer clojure implementation yet. But I will try and see what I can do. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---