You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Hari Shankar <sh...@gmail.com> on 2018/07/24 02:30:43 UTC
Extending ConjunctionSpan
Hi Devs,
Is there a reason why ConjunctionSpans class is package-private? I am
trying to write a custom implementation of Spans which can benefit from
ConjunctionSpans, but I am having to end up copying the code because of
this. Is it ok for me to send a patch making it protected? Or even public
maybe?
Thanks,
Hari
Re: Extending ConjunctionSpan
Posted by Hari Shankar <sh...@gmail.com>.
Cool, created https://issues.apache.org/jira/browse/LUCENE-8426
On Mon, Jul 23, 2018 at 7:40 PM David Smiley <da...@gmail.com>
wrote:
> Hi,
>
> Please file an issue. I'm sympathetic to this -- I have also wound up
> copying ConjunctionSpans in a search app that had some custom Spans.
>
> ~ David
>
> On Mon, Jul 23, 2018 at 10:31 PM Hari Shankar <sh...@gmail.com>
> wrote:
>
>> Hi Devs,
>>
>> Is there a reason why ConjunctionSpans class is package-private? I am
>> trying to write a custom implementation of Spans which can benefit from
>> ConjunctionSpans, but I am having to end up copying the code because of
>> this. Is it ok for me to send a patch making it protected? Or even public
>> maybe?
>>
>> Thanks,
>> Hari
>>
> --
> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
> LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
> http://www.solrenterprisesearchserver.com
>
Re: Extending ConjunctionSpan
Posted by David Smiley <da...@gmail.com>.
Hi,
Please file an issue. I'm sympathetic to this -- I have also wound up
copying ConjunctionSpans in a search app that had some custom Spans.
~ David
On Mon, Jul 23, 2018 at 10:31 PM Hari Shankar <sh...@gmail.com> wrote:
> Hi Devs,
>
> Is there a reason why ConjunctionSpans class is package-private? I am
> trying to write a custom implementation of Spans which can benefit from
> ConjunctionSpans, but I am having to end up copying the code because of
> this. Is it ok for me to send a patch making it protected? Or even public
> maybe?
>
> Thanks,
> Hari
>
--
Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
http://www.solrenterprisesearchserver.com