You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2023/04/18 10:52:04 UTC
[GitHub] [doris] git-hulk opened a new pull request, #18789: Fix segment fault if the PID_DIR wasn't set
git-hulk opened a new pull request, #18789:
URL: https://github.com/apache/doris/pull/18789
# Proposed changes
Issue Number: close #18788
## Problem summary
Doris BE would crash if the PID_DIR wasn't set
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #18789: Fix segment fault if the PID_DIR was NOT set
Posted by "carlvinhust2012 (via GitHub)" <gi...@apache.org>.
carlvinhust2012 commented on code in PR #18789:
URL: https://github.com/apache/doris/pull/18789#discussion_r1169883773
##########
be/src/service/doris_main.cpp:
##########
@@ -282,6 +282,10 @@ int main(int argc, char** argv) {
fprintf(stderr, "you need set DORIS_HOME environment variable.\n");
exit(-1);
}
+ if (getenv("PID_DIR") == nullptr) {
Review Comment:
why not set a default PID_DIR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18789: [bugfix](be): fix segment fault if the PID_DIR was NOT set
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18789:
URL: https://github.com/apache/doris/pull/18789#issuecomment-1515544222
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] git-hulk commented on a diff in pull request #18789: fix(be): fix segment fault if the PID_DIR was NOT set
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on code in PR #18789:
URL: https://github.com/apache/doris/pull/18789#discussion_r1169890813
##########
be/src/service/doris_main.cpp:
##########
@@ -282,6 +282,10 @@ int main(int argc, char** argv) {
fprintf(stderr, "you need set DORIS_HOME environment variable.\n");
exit(-1);
}
+ if (getenv("PID_DIR") == nullptr) {
Review Comment:
Sure, is it good to set it as the current dir like the `start_be` script?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18789: [bugfix](be): fix segment fault if the PID_DIR was NOT set
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18789:
URL: https://github.com/apache/doris/pull/18789#issuecomment-1515544198
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18789: Fix segment fault if the PID_DIR wasn't set
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18789:
URL: https://github.com/apache/doris/pull/18789#issuecomment-1512870489
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18789: [bugfix](be): fix segment fault if the PID_DIR was NOT set
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18789:
URL: https://github.com/apache/doris/pull/18789#issuecomment-1514969133
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] git-hulk commented on a diff in pull request #18789: fix(be): fix segment fault if the PID_DIR was NOT set
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on code in PR #18789:
URL: https://github.com/apache/doris/pull/18789#discussion_r1169890813
##########
be/src/service/doris_main.cpp:
##########
@@ -282,6 +282,10 @@ int main(int argc, char** argv) {
fprintf(stderr, "you need set DORIS_HOME environment variable.\n");
exit(-1);
}
+ if (getenv("PID_DIR") == nullptr) {
Review Comment:
Sure, is it good to set the current dir as default like the `start_be` script?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] git-hulk commented on a diff in pull request #18789: fix(be): fix segment fault if the PID_DIR was NOT set
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on code in PR #18789:
URL: https://github.com/apache/doris/pull/18789#discussion_r1169890813
##########
be/src/service/doris_main.cpp:
##########
@@ -282,6 +282,10 @@ int main(int argc, char** argv) {
fprintf(stderr, "you need set DORIS_HOME environment variable.\n");
exit(-1);
}
+ if (getenv("PID_DIR") == nullptr) {
Review Comment:
Sure, is it good to set the current dir as default like the `start_be` script?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18789: [bugfix](be): fix segment fault if the PID_DIR was NOT set
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18789:
URL: https://github.com/apache/doris/pull/18789#issuecomment-1515544174
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #18789: fix(be): fix segment fault if the PID_DIR was NOT set
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #18789:
URL: https://github.com/apache/doris/pull/18789#issuecomment-1514184902
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #18789: [bugfix](be): fix segment fault if the PID_DIR was NOT set
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #18789:
URL: https://github.com/apache/doris/pull/18789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] git-hulk commented on a diff in pull request #18789: fix(be): fix segment fault if the PID_DIR was NOT set
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on code in PR #18789:
URL: https://github.com/apache/doris/pull/18789#discussion_r1169904968
##########
be/src/service/doris_main.cpp:
##########
@@ -282,6 +282,10 @@ int main(int argc, char** argv) {
fprintf(stderr, "you need set DORIS_HOME environment variable.\n");
exit(-1);
}
+ if (getenv("PID_DIR") == nullptr) {
Review Comment:
I'm not sure if it's good to set the default value here since the start_be also set a default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #18789: [bugfix](be): fix segment fault if the PID_DIR was NOT set
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #18789:
URL: https://github.com/apache/doris/pull/18789#issuecomment-1514203496
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 37.33 seconds
stream load tsv: 436 seconds loaded 74807831229 Bytes, about 163 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 61 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230419063620_clickbench_pr_130915.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org