[GitHub] [drill] arina-ielchiieva edited a comment on issue #1902: DRILL-7448: Fix warnings when running Drill memory tests

[GitBox <gi...@apache.org>]

arina-ielchiieva edited a comment on issue #1902: DRILL-7448: Fix warnings when running Drill memory tests
URL: https://github.com/apache/drill/pull/1902#issuecomment-555522348
 
 
   @KazydubB thanks for making the changes. Discussed this issue with @vvysotskyi, it looks like adding janino dependency to all modules (and then control that it is added in new ones), might be slightly an overhead. I understand that we need to do this to support conditional processing which is mainly used to enable Lilith. On the other hand, we can remove condition, and leave Lilith code commented. Those who need Lilith would have to uncomment this code, instead of setting the variable. I suspect Lilith usage is not that popular in project and there won't be many complaints about it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services