You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/10 07:16:04 UTC
[jira] [Commented] (ARTEMIS-1156) Long Autoboxing occurring on Hot
Path
[ https://issues.apache.org/jira/browse/ARTEMIS-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004201#comment-16004201 ]
ASF GitHub Bot commented on ARTEMIS-1156:
-----------------------------------------
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1263
ARTEMIS-1156: FIX: Long Autoboxing occurring on Hot Path
Building on ARTEMIS-905 JCtools ConcurrentMap replacement first proposed but currently parked by @franz1981, replace the collections with primitive key concurrent collections to avoid auto boxing.
The goal of this is to reduce/remove autoboxing on the hot path.
We are just adding jctools to the broker (should not be in client dependencies)
Like wise targeting specific use case with specific implementation rather than a blanket replace all.
We have to create our own primitive long concurrent hash set, based on jctools as jctools currently don't have one.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1156
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1263
----
commit 7f8b0077a6717f023387c1bc42db23229c47a9c6
Author: Michael Andre Pearce <mi...@me.com>
Date: 2017-05-10T07:13:24Z
ARTEMIS-1156: FIX: Long Autoboxing occurring on Hot Path
Building on ARTEMIS-905 JCtools ConcurrentMap replacement first proposed but currently parked by @franz1981, replace the collections with primitive key concurrent collections to avoid auto boxing.
The goal of this is to reduce/remove autoboxing on the hot path.
We are just adding jctools to the broker (should not be in client dependencies)
Like wise targeting specific use case with specific implementation rather than a blanket replace all.
We have to create our own primitive long concurrent hash set, based on jctools as jctools currently don't have one.
----
> Long Autoboxing occurring on Hot Path
> -------------------------------------
>
> Key: ARTEMIS-1156
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1156
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.0.0
> Reporter: Michael Andre Pearce (IG)
> Attachments: Screen Shot 2017-05-10 at 02.05.47.png
>
>
> JournalImpl is on the hot path, and whilst a lot of effort seems to have gone into ensuring the use of primitives, unfortunately due to java collections used it is forcing long id's to be auto boxed, this causes un-needed memory pressures.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)