[GitHub] [geode] onichols-pivotal opened a new pull request #6978: GEODE-9629: remove factory method added to public API

[GitBox <gi...@apache.org>]

onichols-pivotal opened a new pull request #6978:
URL: https://github.com/apache/geode/pull/6978


   first two fixes removed an errant setter (#6915) and getter (#6972).  This fix removes a factory method that was missed in the first two passes.  All were introduced in 1.15, so removing now before we ship 1.15.0 does not break compatibility with any released version of Geode.
   
   Adding new methods to a public interface like GatewaySenderFactory is a breaking change for other implementations of this interface. We can consider bringing these only when a new major is proposed (e.g. Geode 2.0).
   
   The Geode code that uses this factory method already uses InernalGatewaySenderFactory anyway, so the easiest fix is just to push this down for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] onichols-pivotal merged pull request #6978: GEODE-9629: remove factory method added to public API

[GitBox <gi...@apache.org>]

onichols-pivotal merged pull request #6978:
URL: https://github.com/apache/geode/pull/6978


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org