You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "jiayuasu (via GitHub)" <gi...@apache.org> on 2023/11/29 04:41:14 UTC

Re: [PR] [SEDONA-436] Fix RS_SetValues bug [sedona]

jiayuasu commented on code in PR #1132:
URL: https://github.com/apache/sedona/pull/1132#discussion_r1408729516


##########
common/src/main/java/org/apache/sedona/common/raster/PixelFunctionEditors.java:
##########
@@ -122,7 +122,7 @@ public static GridCoverage2D setValues(GridCoverage2D raster, int band, Geometry
 
         Raster rasterizedGeomData = RasterUtils.getRaster(rasterizedGeom.getRenderedImage());
         double colX = RasterAccessors.getUpperLeftX(rasterizedGeom), rowY = RasterAccessors.getUpperLeftY(rasterizedGeom);
-        int height = RasterAccessors.getHeight(rasterizedGeom), width = RasterAccessors.getWidth(rasterizedGeom);
+        int heightGeometryRaster = RasterAccessors.getHeight(rasterizedGeom), widthGeometryRaster = RasterAccessors.getWidth(rasterizedGeom);

Review Comment:
   We should had captured this bug before. Can you add a test to capture this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org