You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/09 09:44:26 UTC

[GitHub] [skywalking] JohnNiang opened a new pull request #4333: Make an alternative method while cloning

JohnNiang opened a new pull request #4333:  Make an alternative method while cloning
URL: https://github.com/apache/skywalking/pull/4333
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [x] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   https://github.com/apache/skywalking/issues/4331
   ___
   ### New feature or improvement
   
   Make an alternative method while cloning and reformat some code blocks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4333: Make an alternative method while cloning

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4333:  Make an alternative method while cloning
URL: https://github.com/apache/skywalking/pull/4333#issuecomment-583828641
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4333?src=pr&el=h1) Report
   > Merging [#4333](https://codecov.io/gh/apache/skywalking/pull/4333?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/68bf8cb8be772843b59fd957e84120edb81f4fb7?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `93.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4333/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4333?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4333      +/-   ##
   ==========================================
   + Coverage   27.01%   27.02%   +<.01%     
   ==========================================
     Files        1176     1176              
     Lines       25677    25677              
     Branches     3664     3664              
   ==========================================
   + Hits         6936     6938       +2     
   + Misses      18128    18127       -1     
   + Partials      613      612       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4333?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../core/profile/analyze/ProfileAnalyzeCollector.java](https://codecov.io/gh/apache/skywalking/pull/4333/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVBbmFseXplQ29sbGVjdG9yLmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
   | [...lking/oap/query/graphql/resolver/ProfileQuery.java](https://codecov.io/gh/apache/skywalking/pull/4333/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL1Byb2ZpbGVRdWVyeS5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/4333/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `90.38% <100%> (ø)` | :arrow_up: |
   | [...p/server/core/profile/analyze/ProfileAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4333/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVBbmFseXplci5qYXZh) | `77.77% <100%> (ø)` | :arrow_up: |
   | [...oap/server/core/query/entity/ProfileStackTree.java](https://codecov.io/gh/apache/skywalking/pull/4333/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvZW50aXR5L1Byb2ZpbGVTdGFja1RyZWUuamF2YQ==) | `100% <100%> (ø)` | :arrow_up: |
   | [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4333/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `83.6% <0%> (+3.27%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4333?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4333?src=pr&el=footer). Last update [68bf8cb...ca999d4](https://codecov.io/gh/apache/skywalking/pull/4333?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] JohnNiang commented on issue #4333: Make an alternative method while cloning

Posted by GitBox <gi...@apache.org>.
JohnNiang commented on issue #4333:  Make an alternative method while cloning
URL: https://github.com/apache/skywalking/pull/4333#issuecomment-583825317
 
 
   Preiview: <https://github.com/JohnNiang/skywalking/blob/chore/doc/docs/en/guides/How-to-build.md>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] JohnNiang commented on a change in pull request #4333: Make an alternative method while cloning

Posted by GitBox <gi...@apache.org>.
JohnNiang commented on a change in pull request #4333:  Make an alternative method while cloning
URL: https://github.com/apache/skywalking/pull/4333#discussion_r376769468
 
 

 ##########
 File path: docs/en/guides/How-to-build.md
 ##########
 @@ -17,11 +17,19 @@ If you need to execute build behind the proxy, edit the *.mvn/jvm.config* and pu
 
 ### Build from GitHub
 1. Prepare git, JDK8 and maven3
-1. `git clone https://github.com/apache/skywalking.git`
-1. `cd skywalking/`
+1. Clone project
+    ```bash
+    git clone --recurse-submodules https://github.com/apache/skywalking.git
+    cd skywalking/
+    
+    OR
+    
+    git clone https://github.com/apache/skywalking.git
+    cd skywalking/
+    git submodule init
+    git submodule update
 
 Review comment:
   Got it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] JohnNiang commented on a change in pull request #4333: Make an alternative method while cloning

Posted by GitBox <gi...@apache.org>.
JohnNiang commented on a change in pull request #4333:  Make an alternative method while cloning
URL: https://github.com/apache/skywalking/pull/4333#discussion_r376769992
 
 

 ##########
 File path: docs/en/guides/How-to-build.md
 ##########
 @@ -17,11 +17,19 @@ If you need to execute build behind the proxy, edit the *.mvn/jvm.config* and pu
 
 ### Build from GitHub
 1. Prepare git, JDK8 and maven3
-1. `git clone https://github.com/apache/skywalking.git`
-1. `cd skywalking/`
+1. Clone project
+    ```bash
+    git clone --recurse-submodules https://github.com/apache/skywalking.git
+    cd skywalking/
+    
+    OR
+    
+    git clone https://github.com/apache/skywalking.git
+    cd skywalking/
+    git submodule init
+    git submodule update
 
 Review comment:
   Maybe we could specify the branch name / tag name in the after `git clone` command.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] JohnNiang commented on a change in pull request #4333: Make an alternative method while cloning

Posted by GitBox <gi...@apache.org>.
JohnNiang commented on a change in pull request #4333:  Make an alternative method while cloning
URL: https://github.com/apache/skywalking/pull/4333#discussion_r376769992
 
 

 ##########
 File path: docs/en/guides/How-to-build.md
 ##########
 @@ -17,11 +17,19 @@ If you need to execute build behind the proxy, edit the *.mvn/jvm.config* and pu
 
 ### Build from GitHub
 1. Prepare git, JDK8 and maven3
-1. `git clone https://github.com/apache/skywalking.git`
-1. `cd skywalking/`
+1. Clone project
+    ```bash
+    git clone --recurse-submodules https://github.com/apache/skywalking.git
+    cd skywalking/
+    
+    OR
+    
+    git clone https://github.com/apache/skywalking.git
+    cd skywalking/
+    git submodule init
+    git submodule update
 
 Review comment:
   Maybe we could specify the branch name / tag name in the after `git clone command`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io commented on issue #4333: Make an alternative method while cloning

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4333:  Make an alternative method while cloning
URL: https://github.com/apache/skywalking/pull/4333#issuecomment-583828641
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4333?src=pr&el=h1) Report
   > Merging [#4333](https://codecov.io/gh/apache/skywalking/pull/4333?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/68bf8cb8be772843b59fd957e84120edb81f4fb7?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `93.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4333/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4333?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #4333   +/-   ##
   =======================================
     Coverage   27.01%   27.01%           
   =======================================
     Files        1176     1176           
     Lines       25677    25677           
     Branches     3664     3664           
   =======================================
     Hits         6936     6936           
     Misses      18128    18128           
     Partials      613      613
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4333?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../core/profile/analyze/ProfileAnalyzeCollector.java](https://codecov.io/gh/apache/skywalking/pull/4333/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVBbmFseXplQ29sbGVjdG9yLmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
   | [...lking/oap/query/graphql/resolver/ProfileQuery.java](https://codecov.io/gh/apache/skywalking/pull/4333/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL1Byb2ZpbGVRdWVyeS5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [...p/server/core/profile/analyze/ProfileAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4333/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVBbmFseXplci5qYXZh) | `77.77% <100%> (ø)` | :arrow_up: |
   | [...oap/server/core/query/entity/ProfileStackTree.java](https://codecov.io/gh/apache/skywalking/pull/4333/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvZW50aXR5L1Byb2ZpbGVTdGFja1RyZWUuamF2YQ==) | `100% <100%> (ø)` | :arrow_up: |
   | [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/4333/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `90.38% <100%> (ø)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4333?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4333?src=pr&el=footer). Last update [68bf8cb...6553389](https://codecov.io/gh/apache/skywalking/pull/4333?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng merged pull request #4333: Make an alternative method while cloning

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4333:  Make an alternative method while cloning
URL: https://github.com/apache/skywalking/pull/4333
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4333: Make an alternative method while cloning

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4333:  Make an alternative method while cloning
URL: https://github.com/apache/skywalking/pull/4333#discussion_r376769377
 
 

 ##########
 File path: docs/en/guides/How-to-build.md
 ##########
 @@ -17,11 +17,19 @@ If you need to execute build behind the proxy, edit the *.mvn/jvm.config* and pu
 
 ### Build from GitHub
 1. Prepare git, JDK8 and maven3
-1. `git clone https://github.com/apache/skywalking.git`
-1. `cd skywalking/`
+1. Clone project
+    ```bash
+    git clone --recurse-submodules https://github.com/apache/skywalking.git
+    cd skywalking/
+    
+    OR
+    
+    git clone https://github.com/apache/skywalking.git
+    cd skywalking/
+    git submodule init
+    git submodule update
 
 Review comment:
   Your step is not right, because branch change could relate to submodule change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services