[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

["Tim Armstrong (Code Review)" <ge...@cloudera.org>]

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 )

Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro
......................................................................


Patch Set 8:

(1 comment)

There's a fair bit of codegen logic in this patch - maybe you could take a look Thomas since you've been looking at codegen recently?

http://gerrit.cloudera.org:8080/#/c/8146/6/be/src/runtime/tuple.cc
File be/src/runtime/tuple.cc:

http://gerrit.cloudera.org:8080/#/c/8146/6/be/src/runtime/tuple.cc@448
PS6, Line 448:   Value* constant_slot_offsets_first_element_ptr =
Weird ordering of statements.



-- 
To view, visit http://gerrit.cloudera.org:8080/8146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1fc78790d778c874f5aafa5958c3c045a88d233
Gerrit-Change-Number: 8146
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Oct 2017 17:26:12 +0000
Gerrit-HasComments: Yes