[jira] [Commented] (OAK-3412) Node name having non space whitspace chars should not be allowed

["Vinay Gupta (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991336#comment-14991336 ] 

Vinay Gupta commented on OAK-3412:
----------------------------------

There are characters like [U+3000|https://codepoints.net/U+3000] which are whitespace but not [SP|https://codepoints.net/U+0020]. This particular character is part of [CJK Symbols & Punctuation|https://codepoints.net/cjk_symbols_and_punctuation] which is used in Chinese, Japanese and Korean scripts. Not allowing these characters has lot of impact, as they need to be avoided specifically.

These characters are well supported in products like Dropbox & Google Drive. I think we should reconsider adding this support with the consideration of multiple scripts used in different parts of the world.

> Node name having non space whitspace chars should not be allowed
> ----------------------------------------------------------------
>
>                 Key: OAK-3412
>                 URL: https://issues.apache.org/jira/browse/OAK-3412
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>             Fix For: 1.3.7, 1.2.7, 1.0.22
>
>         Attachments: OAK-3412.patch
>
>
> Due to the changes done in OAK-1174 node with non space whitespace chars like '\n', '\r' etc can be created. This is not desirable and also JR2 does not allow such node to be created so check must be added to prevent such a name from getting created.
> As discussed in [1] this is regression due to usage of incorrect utility method as part of [2] the fix can be simply using a {{Character#isWhitespace}} instead of {{Character#isSpaceChar}}
> [1] http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201509.mbox/%3CCAHCW-mkkGtxkn%2B9xfXuvMTfgykewjMPsLwrVH%2B00%2BXaBQjA0sg%40mail.gmail.com%3E
> [2] https://github.com/apache/jackrabbit-oak/commit/342809f7f04221782ca6bbfbde9392ec4ff441c2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)