[GitHub] [echarts] JinJianQi commented on a diff in pull request #17288: feat: add the insideDataZoom 'gestureOnTouchPad' option that can Optimize the Experience on the MAC touchpad.

[GitBox <gi...@apache.org>]

JinJianQi commented on code in PR #17288:
URL: https://github.com/apache/echarts/pull/17288#discussion_r931954030


##########
src/component/helper/RoamController.ts:
##########
@@ -242,6 +252,44 @@ class RoamController extends Eventful<{
         // their event both, and the final behavior is determined
         // by event listener themselves.
 
+        if (gestureOnTouchPad) {
+          const WindowScrollSpeedFactor = .3;

Review Comment:
   Yeah, Thanks a lot @Ovilia, I would like to add scrolling both directions as a feature. So I think this not a bug. the name `natureMoveOnMouseWheel` is good for me.
   
   And also, I already set `gestureOnTouchPad` as an options adjust with 
   ```
   zoomOnMouseWheel: false,
   moveOnMouseWheel: true,
   ```
   now it looks like:
   ```
   zoomOnMouseWheel: false,
   moveOnMouseWheel: true,
   gestureOnTouchPad: true,
   ```
   Users can set this option use `setOption();`
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org