[GitHub] [superset] michael-s-molina commented on pull request #20743: feat: Pass dashboard context to explore through local storage

[GitBox <gi...@apache.org>]

michael-s-molina commented on PR #20743:
URL: https://github.com/apache/superset/pull/20743#issuecomment-1190382088

   Thanks for the PR @kgabryje. This is a nice improvement now that we have the permalink feature in place and form data keys are not shared anymore.
   
   I noticed that the `form_data_key` is still being generated in Explore. Is there a reason for it? If it's not needed, can we remove it and mark the `explore/form_data` endpoint as deprecated? You can add a [deprecation warning](https://github.com/apache/superset/blob/81bd4968d0a916cb2a20e47b20e31a1434be4f46/superset/views/core.py#L750) to the API file.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org