You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2017/02/21 19:35:13 UTC
Review Request 56897: ATLAS-1577: audit event generated for an entity
overwrites previous audit event for the entity
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56897/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1577
https://issues.apache.org/jira/browse/ATLAS-1577
Repository: atlas
Description
-------
The key for audit log (in HBase) is generated using the entity-guid and the request-time. With the changes in ATLAS-1499, the request-time used here was not populated - resulting in earlier audit log be overwritten. Updated to populate request-time to address this issue.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java e4dcfca
server-api/src/main/java/org/apache/atlas/RequestContext.java d35f456
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 44c7995
webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java d804f21
Diff: https://reviews.apache.org/r/56897/diff/
Testing
-------
- Verified that audit logs for an entity don't overwrite the previous log, by performaing the following in Hive:
-- create a table
-- alter the table by adding a column
-- delete the table
Thanks,
Madhan Neethiraj
Re: Review Request 56897: ATLAS-1577: audit event generated for an
entity overwrites previous audit event for the entity
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56897/#review166214
-----------------------------------------------------------
Ship it!
Ship It!
- Apoorv Naik
On Feb. 21, 2017, 7:35 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56897/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 7:35 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1577
> https://issues.apache.org/jira/browse/ATLAS-1577
>
>
> Repository: atlas
>
>
> Description
> -------
>
> The key for audit log (in HBase) is generated using the entity-guid and the request-time. With the changes in ATLAS-1499, the request-time used here was not populated - resulting in earlier audit log be overwritten. Updated to populate request-time to address this issue.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java e4dcfca
> server-api/src/main/java/org/apache/atlas/RequestContext.java d35f456
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 44c7995
> webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java d804f21
>
> Diff: https://reviews.apache.org/r/56897/diff/
>
>
> Testing
> -------
>
> - Verified that audit logs for an entity don't overwrite the previous log, by performaing the following in Hive:
> -- create a table
> -- alter the table by adding a column
> -- delete the table
>
>
> Thanks,
>
> Madhan Neethiraj
>
>