You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/20 03:48:59 UTC
[GitHub] [rocketmq] complone opened a new pull request, #5362: [ISSUE#5257] rocketmq timed task configuration simplify
complone opened a new pull request, #5362:
URL: https://github.com/apache/rocketmq/pull/5362
**Make sure set the target branch to `develop`**
## What is the purpose of the change
related to [issue-5257](https://github.com/apache/rocketmq/issues/5257)
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE#5257] Simplify RocketMQ timed task configuration [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5362: [ISSUE#5257] Simplify RocketMQ timed task configuration
URL: https://github.com/apache/rocketmq/pull/5362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE#5257] Simplify RocketMQ timed task configuration [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5362:
URL: https://github.com/apache/rocketmq/pull/5362#issuecomment-1793586896
This PR was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] complone commented on pull request #5362: [ISSUE#5257] rocketmq timed task configuration simplify
Posted by GitBox <gi...@apache.org>.
complone commented on PR #5362:
URL: https://github.com/apache/rocketmq/pull/5362#issuecomment-1286415830
> Great idea, but I believe these types of variables that are not available for modification could be maintained as constants. And pls also keep in mind that do not include too many changes (e.g., format correction) that are not related to the original problem, you could maybe open another PR to improve it.
Thanks for the suggestion, I'll do it internally today,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE#5257] Simplify RocketMQ timed task configuration [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5362:
URL: https://github.com/apache/rocketmq/pull/5362#issuecomment-1788200083
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] complone commented on pull request #5362: [ISSUE#5257] rocketmq timed task configuration simplify
Posted by GitBox <gi...@apache.org>.
complone commented on PR #5362:
URL: https://github.com/apache/rocketmq/pull/5362#issuecomment-1286379718
I will fix the relevant unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] complone commented on pull request #5362: [ISSUE#5257] Simplify RocketMQ timed task configuration
Posted by GitBox <gi...@apache.org>.
complone commented on PR #5362:
URL: https://github.com/apache/rocketmq/pull/5362#issuecomment-1297095062
> Hi @complone You can import rocketmq code style xml for develop tools.
Thank you for your reply. I'm a little unhappy recently. I'll update this PR in two days
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org