[GitHub] DaanHoogland commented on a change in pull request #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart
URL: https://github.com/apache/cloudstack/pull/2427#discussion_r163482774
 
 

 ##########
 File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
 ##########
 @@ -49,15 +49,21 @@ def process(self):
             self.add(self.dbag[item])
         self.write_hosts()
 
-        if self.cloud.is_changed():
-            self.delete_leases()
-
         self.configure_server()
 
-        restart_dnsmasq = self.conf.commit()
-        self.cloud.commit()
+        restart_dnsmasq = False
+
+        if self.conf.commit():
+            restart_dnsmasq = True
+
+        if self.cloud.commit():
 
 Review comment:
   I see conf.commit and cloud.commit. Those are two different objects, @resmo . How is this suspect?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services