You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/07/05 21:34:48 UTC
[GitHub] flink pull request #6270: [FLINK-9769][rest] Clear FileUpload attribute afte...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6270
[FLINK-9769][rest] Clear FileUpload attribute after access
## What is the purpose of the change
Prevents a resource leakage by clearing the `UPLOADED_FILES` attribute after accessing it.
Previously it could happen that a handler might see the result of a file upload operation if it happened to be sharing the same channel. In this case said files were already cleaned up, leading to `FileNotFoundExceptions`.
## Verifying this change
Manually verified. Submit a job via the Web UI, no exception should be logged.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 9769
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6270.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6270
----
commit 56af2054970dc3282b28dfc8cac4b0a4142bf1ab
Author: zentol <ch...@...>
Date: 2018-07-05T21:28:47Z
[FLINK-9769][rest] Clear FileUpload attribute after access
----
---
[GitHub] flink issue #6270: [FLINK-9769][rest] Clear FileUpload attribute after acces...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6270
How does it happen that Netty channels are shared @zentol?
---
[GitHub] flink issue #6270: [FLINK-9769][rest] Clear FileUpload attribute after acces...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6270
merging.
---
[GitHub] flink pull request #6270: [FLINK-9769][rest] Clear FileUpload attribute afte...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6270
---
[GitHub] flink issue #6270: [FLINK-9769][rest] Clear FileUpload attribute after acces...
Posted by medcv <gi...@git.apache.org>.
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6270
+1
I rebuilt the 1.5.1 with this changes and now `Upload` jar file from WebUI working.
---
[GitHub] flink issue #6270: [FLINK-9769][rest] Clear FileUpload attribute after acces...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6270
Ultimately this should happen if the client sets the `keep-alive` flag on the first request.
One thing i observed is that it appears to be gated by time. Uploading a jar immediately triggers the JarListHandler, leading to the log message posted in the JIRA. However refreshing the page or manually pinging the listing causes no such thing.
---