You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Rogers Reilly (JIRA)" <ad...@incubator.apache.org> on 2006/05/08 01:50:20 UTC
[jira] Created: (ADFFACES-2) add init-param to make "dialog:xxx"
prefix configurable
add init-param to make "dialog:xxx" prefix configurable
-------------------------------------------------------
Key: ADFFACES-2
URL: http://issues.apache.org/jira/browse/ADFFACES-2
Project: MyFaces ADF-Faces
Type: Improvement
Reporter: Rogers Reilly
Priority: Minor
In order to use ADF dialogs, the dialog's beginning view-state must start with the prefix "dialog". This causes problems when simultaneously using, for example, Shale, as Shale assumes "dialog:xxx" is referencing a Shale dialog.
Request is for an optional init-param to specifiy an alternative prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-2) add init-param to make "dialog:xxx"
prefix configurable
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-2?page=comments#action_12419384 ]
Matthias Weßendorf commented on ADFFACES-2:
-------------------------------------------
I change that on my box tonight, when *checking* the patch.
Thanks Pierre
> add init-param to make "dialog:xxx" prefix configurable
> -------------------------------------------------------
>
> Key: ADFFACES-2
> URL: http://issues.apache.org/jira/browse/ADFFACES-2
> Project: MyFaces ADF-Faces
> Type: Improvement
> Reporter: Rogers Reilly
> Assignee: Matthias Weßendorf
> Priority: Minor
> Attachments: Modification_done.txt, NavigationHandlerImpl.txt
>
> In order to use ADF dialogs, the dialog's beginning view-state must start with the prefix "dialog". This causes problems when simultaneously using, for example, Shale, as Shale assumes "dialog:xxx" is referencing a Shale dialog.
> Request is for an optional init-param to specifiy an alternative prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-2) add init-param to make "dialog:xxx"
prefix configurable
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated ADFFACES-2:
--------------------------------------
Fix Version/s: 1.0.0-incubating-core
Affects Version/s: 1.0.0-incubating-core
> add init-param to make "dialog:xxx" prefix configurable
> -------------------------------------------------------
>
> Key: ADFFACES-2
> URL: https://issues.apache.org/jira/browse/ADFFACES-2
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Affects Versions: 1.0.0-incubating-core
> Reporter: Rogers Reilly
> Assigned To: Matthias Weßendorf
> Priority: Minor
> Fix For: 1.0.0-incubating-core
>
> Attachments: Modification_done.txt, NavigationHandlerImpl.txt
>
>
> In order to use ADF dialogs, the dialog's beginning view-state must start with the prefix "dialog". This causes problems when simultaneously using, for example, Shale, as Shale assumes "dialog:xxx" is referencing a Shale dialog.
> Request is for an optional init-param to specifiy an alternative prefix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ADFFACES-2) add init-param to make "dialog:xxx"
prefix configurable
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-2?page=comments#action_12419563 ]
Matthias Weßendorf commented on ADFFACES-2:
-------------------------------------------
Hey Pierre,
I really appreciate your efforts, but to make life easier for us, it is recommented to provide a svn dif file.
:-)
For now I make it manually, but please have this in mind in the future.
thanks for the patch!
> add init-param to make "dialog:xxx" prefix configurable
> -------------------------------------------------------
>
> Key: ADFFACES-2
> URL: http://issues.apache.org/jira/browse/ADFFACES-2
> Project: MyFaces ADF-Faces
> Type: Improvement
> Reporter: Rogers Reilly
> Assignee: Matthias Weßendorf
> Priority: Minor
> Attachments: Modification_done.txt, NavigationHandlerImpl.txt
>
> In order to use ADF dialogs, the dialog's beginning view-state must start with the prefix "dialog". This causes problems when simultaneously using, for example, Shale, as Shale assumes "dialog:xxx" is referencing a Shale dialog.
> Request is for an optional init-param to specifiy an alternative prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-2) add init-param to make "dialog:xxx"
prefix configurable
Posted by "Craig McClanahan (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-2?page=comments#action_12378375 ]
Craig McClanahan commented on ADFFACES-2:
-----------------------------------------
I just added a corresponding RFE on Shale to make the prefix configurable:
http://issues.apache.org/struts/browse/SHALE-173
> add init-param to make "dialog:xxx" prefix configurable
> -------------------------------------------------------
>
> Key: ADFFACES-2
> URL: http://issues.apache.org/jira/browse/ADFFACES-2
> Project: MyFaces ADF-Faces
> Type: Improvement
> Reporter: Rogers Reilly
> Priority: Minor
>
> In order to use ADF dialogs, the dialog's beginning view-state must start with the prefix "dialog". This causes problems when simultaneously using, for example, Shale, as Shale assumes "dialog:xxx" is referencing a Shale dialog.
> Request is for an optional init-param to specifiy an alternative prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-2) add init-param to make "dialog:xxx"
prefix configurable
Posted by "Pierre-Luc Archambault (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-2?page=all ]
Pierre-Luc Archambault updated ADFFACES-2:
------------------------------------------
Attachment: Modification_done.txt
Added a second file noting only the modification done in the NagivationHandlerImpl.java
> add init-param to make "dialog:xxx" prefix configurable
> -------------------------------------------------------
>
> Key: ADFFACES-2
> URL: http://issues.apache.org/jira/browse/ADFFACES-2
> Project: MyFaces ADF-Faces
> Type: Improvement
> Reporter: Rogers Reilly
> Priority: Minor
> Attachments: Modification_done.txt, NavigationHandlerImpl.txt
>
> In order to use ADF dialogs, the dialog's beginning view-state must start with the prefix "dialog". This causes problems when simultaneously using, for example, Shale, as Shale assumes "dialog:xxx" is referencing a Shale dialog.
> Request is for an optional init-param to specifiy an alternative prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (ADFFACES-2) add init-param to make "dialog:xxx"
prefix configurable
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-2?page=all ]
Matthias Weßendorf reassigned ADFFACES-2:
-----------------------------------------
Assign To: Matthias Weßendorf
> add init-param to make "dialog:xxx" prefix configurable
> -------------------------------------------------------
>
> Key: ADFFACES-2
> URL: http://issues.apache.org/jira/browse/ADFFACES-2
> Project: MyFaces ADF-Faces
> Type: Improvement
> Reporter: Rogers Reilly
> Assignee: Matthias Weßendorf
> Priority: Minor
> Attachments: Modification_done.txt, NavigationHandlerImpl.txt
>
> In order to use ADF dialogs, the dialog's beginning view-state must start with the prefix "dialog". This causes problems when simultaneously using, for example, Shale, as Shale assumes "dialog:xxx" is referencing a Shale dialog.
> Request is for an optional init-param to specifiy an alternative prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-2) add init-param to make "dialog:xxx"
prefix configurable
Posted by "Pierre-Luc Archambault (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-2?page=all ]
Pierre-Luc Archambault updated ADFFACES-2:
------------------------------------------
Attachment: NavigationHandlerImpl.txt
The following modification was done in the NavigationHandlerImpl.java file
Added a private variable containing either the user custom URL input or the default one that was already there for "dialog:" identification.
Also, the only required field to be added in web.xml would be :
<context-param>
<param-name>org.apache.myfaces.trinidad.DIALOG_PREFIX</param-name>
<param-value>userInputHere:</param-value>
</context-param>
> add init-param to make "dialog:xxx" prefix configurable
> -------------------------------------------------------
>
> Key: ADFFACES-2
> URL: http://issues.apache.org/jira/browse/ADFFACES-2
> Project: MyFaces ADF-Faces
> Type: Improvement
> Reporter: Rogers Reilly
> Priority: Minor
> Attachments: NavigationHandlerImpl.txt
>
> In order to use ADF dialogs, the dialog's beginning view-state must start with the prefix "dialog". This causes problems when simultaneously using, for example, Shale, as Shale assumes "dialog:xxx" is referencing a Shale dialog.
> Request is for an optional init-param to specifiy an alternative prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (ADFFACES-2) add init-param to make "dialog:xxx"
prefix configurable
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-2?page=all ]
Matthias Weßendorf closed ADFFACES-2:
-------------------------------------
Resolution: Fixed
tx for the patch Pierre
> add init-param to make "dialog:xxx" prefix configurable
> -------------------------------------------------------
>
> Key: ADFFACES-2
> URL: http://issues.apache.org/jira/browse/ADFFACES-2
> Project: MyFaces ADF-Faces
> Type: Improvement
> Reporter: Rogers Reilly
> Assignee: Matthias Weßendorf
> Priority: Minor
> Attachments: Modification_done.txt, NavigationHandlerImpl.txt
>
> In order to use ADF dialogs, the dialog's beginning view-state must start with the prefix "dialog". This causes problems when simultaneously using, for example, Shale, as Shale assumes "dialog:xxx" is referencing a Shale dialog.
> Request is for an optional init-param to specifiy an alternative prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-2) add init-param to make "dialog:xxx"
prefix configurable
Posted by "Pierre-Luc Archambault (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-2?page=all ]
Pierre-Luc Archambault updated ADFFACES-2:
------------------------------------------
Status: Patch Available (was: Open)
> add init-param to make "dialog:xxx" prefix configurable
> -------------------------------------------------------
>
> Key: ADFFACES-2
> URL: http://issues.apache.org/jira/browse/ADFFACES-2
> Project: MyFaces ADF-Faces
> Type: Improvement
> Reporter: Rogers Reilly
> Priority: Minor
>
> In order to use ADF dialogs, the dialog's beginning view-state must start with the prefix "dialog". This causes problems when simultaneously using, for example, Shale, as Shale assumes "dialog:xxx" is referencing a Shale dialog.
> Request is for an optional init-param to specifiy an alternative prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-2) add init-param to make "dialog:xxx"
prefix configurable
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-2?page=comments#action_12419370 ]
Adam Winer commented on ADFFACES-2:
-----------------------------------
For now, the parameter should be org.apache.myfaces.adf.DIALOG_NAVIGATION_PREFIX. DIALOG_NAVIGATION_PREFIX, so it'll be more descriptive, and "adf" instead of "trinidad" so that we can do all ADF -> Trinidad changes at the same time.
> add init-param to make "dialog:xxx" prefix configurable
> -------------------------------------------------------
>
> Key: ADFFACES-2
> URL: http://issues.apache.org/jira/browse/ADFFACES-2
> Project: MyFaces ADF-Faces
> Type: Improvement
> Reporter: Rogers Reilly
> Assignee: Matthias Weßendorf
> Priority: Minor
> Attachments: Modification_done.txt, NavigationHandlerImpl.txt
>
> In order to use ADF dialogs, the dialog's beginning view-state must start with the prefix "dialog". This causes problems when simultaneously using, for example, Shale, as Shale assumes "dialog:xxx" is referencing a Shale dialog.
> Request is for an optional init-param to specifiy an alternative prefix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira