You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/10 14:35:01 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
rkhachatryan opened a new pull request #17757:
URL: https://github.com/apache/flink/pull/17757
Cloned from #17387 to only include changelog metrics (not the TMJMG lifecycle change) eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* a0be72236b756fc85c2c6bd21900f276bfad7270 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* c81ce387e77568b32e16adb5a129e36a00a6bae9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-966244028
@pnowojski I've changed the design per your suggestion: moved `ChangelogStorageMetricGroup` to the job level (`TaskManagerJobMetricGroup`) and to `flink-dstl-dfs` module.
That required to change the `TaskManagerJobMetricGroup` lifecycle, so I've split the change into two PRs (this one adds new metrics).
Could you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r754403927
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
+public class ChangelogStorageMetricGroup extends ProxyMetricGroup<MetricGroup> {
+ private static final int WINDOW_SIZE = 1000;
+
+ private final Counter uploadsCounter;
+ private final Counter uploadFailures;
+ private final Histogram logsPerUpload;
+ private final Histogram uploadSizes;
+ private final Histogram uploadLatencies;
+ private final Histogram attemptsPerUpload;
+
+ public ChangelogStorageMetricGroup(MetricGroup parent) {
+ super(parent);
+ this.uploadsCounter = counter(CHANGELOG_STORAGE_UPLOAD_REQUESTS, new ThreadSafeCounter());
+ this.logsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_LOGS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.attemptsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadSizes =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_SIZES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadLatencies =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_LATENCIES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadFailures = counter(CHANGELOG_STORAGE_UPLOAD_FAILURES, new ThreadSafeCounter());
+ }
+
+ public Counter getUploadsCounter() {
+ return uploadsCounter;
+ }
+
+ public Counter getFailuresCounter() {
+ return uploadFailures;
+ }
+
+ public Histogram getAttemptsPerUpload() {
+ return attemptsPerUpload;
+ }
+
+ public Histogram getLogsPerUpload() {
+ return logsPerUpload;
+ }
+
+ public Histogram getUploadSizes() {
+ return uploadSizes;
+ }
+
+ public Histogram getUploadLatencies() {
+ return uploadLatencies;
+ }
+
+ public void registerQueueSizeGauge(Gauge<Integer> gauge) {
+ gauge(CHANGELOG_STORAGE_QUEUE_SIZE, gauge);
+ }
+
+ private static class ThreadSafeCounter implements Counter {
+ private final LongAdder longAdder = new LongAdder();
+
+ @Override
+ public void inc() {
+ longAdder.increment();
+ }
+
+ @Override
+ public void inc(long n) {
+ longAdder.add(n);
+ }
+
+ @Override
+ public void dec() {
+ longAdder.decrement();
+ }
+
+ @Override
+ public void dec(long n) {
+ longAdder.add(-n);
+ }
+
+ @Override
+ public long getCount() {
+ return longAdder.longValue();
+ }
+ }
+
+ private static final String PREFIX = "changelogStorage";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX + ".uploadRequests";
+ public static final String CHANGELOG_STORAGE_UPLOAD_FAILURES = PREFIX + ".uploadFailures";
+ public static final String CHANGELOG_STORAGE_UPLOAD_SIZES = PREFIX + ".uploadSizes";
+ public static final String CHANGELOG_STORAGE_UPLOAD_LATENCIES = PREFIX + ".uploadLatencies";
+ public static final String CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD =
+ PREFIX + ".attemptsPerUpload";
+ public static final String CHANGELOG_STORAGE_LOGS_PER_UPLOAD = PREFIX + ".logsPerUpload";
Review comment:
Hmmm, `uploadBatchSizes` sounds best to me, but I guess either way it won't be self explanatory to the users so it will need a better explanation in the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r754400823
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
+public class ChangelogStorageMetricGroup extends ProxyMetricGroup<MetricGroup> {
+ private static final int WINDOW_SIZE = 1000;
+
+ private final Counter uploadsCounter;
+ private final Counter uploadFailures;
+ private final Histogram logsPerUpload;
+ private final Histogram uploadSizes;
+ private final Histogram uploadLatencies;
+ private final Histogram attemptsPerUpload;
+
+ public ChangelogStorageMetricGroup(MetricGroup parent) {
+ super(parent);
+ this.uploadsCounter = counter(CHANGELOG_STORAGE_UPLOAD_REQUESTS, new ThreadSafeCounter());
+ this.logsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_LOGS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.attemptsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadSizes =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_SIZES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadLatencies =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_LATENCIES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadFailures = counter(CHANGELOG_STORAGE_UPLOAD_FAILURES, new ThreadSafeCounter());
+ }
+
+ public Counter getUploadsCounter() {
+ return uploadsCounter;
+ }
+
+ public Counter getFailuresCounter() {
+ return uploadFailures;
+ }
+
+ public Histogram getAttemptsPerUpload() {
+ return attemptsPerUpload;
+ }
+
+ public Histogram getLogsPerUpload() {
+ return logsPerUpload;
+ }
+
+ public Histogram getUploadSizes() {
+ return uploadSizes;
+ }
+
+ public Histogram getUploadLatencies() {
+ return uploadLatencies;
+ }
+
+ public void registerQueueSizeGauge(Gauge<Integer> gauge) {
+ gauge(CHANGELOG_STORAGE_QUEUE_SIZE, gauge);
+ }
+
+ private static class ThreadSafeCounter implements Counter {
+ private final LongAdder longAdder = new LongAdder();
+
+ @Override
+ public void inc() {
+ longAdder.increment();
+ }
+
+ @Override
+ public void inc(long n) {
+ longAdder.add(n);
+ }
+
+ @Override
+ public void dec() {
+ longAdder.decrement();
+ }
+
+ @Override
+ public void dec(long n) {
+ longAdder.add(-n);
+ }
+
+ @Override
+ public long getCount() {
+ return longAdder.longValue();
+ }
+ }
+
+ private static final String PREFIX = "changelogStorage";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX + ".uploadRequests";
Review comment:
With `total` I wanted to emphasise that it contains all, both failures and successful? And I drew the inspiration from the existing [checkpoint metrics](https://nightlies.apache.org/flink/flink-docs-master/docs/ops/metrics/), for example `totalNumberOfCheckpoints`.
But `numberOfUploadRequests` is maybe also not bad?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2db1ab776228ba573da1b098ef6692de3b583323 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305)
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 643a25496b3c7ccce9f7c796a095fe5e5be83400 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 643a25496b3c7ccce9f7c796a095fe5e5be83400 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315)
* f5498cd619035e5708a5bde18e0088ace9943d95 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* f5498cd619035e5708a5bde18e0088ace9943d95 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
}, {
"hash" : "d2f18947342620d4e2573f5547385da72042b401",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864",
"triggerID" : "d2f18947342620d4e2573f5547385da72042b401",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* d2f18947342620d4e2573f5547385da72042b401 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
}, {
"hash" : "d2f18947342620d4e2573f5547385da72042b401",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864",
"triggerID" : "d2f18947342620d4e2573f5547385da72042b401",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* d2f18947342620d4e2573f5547385da72042b401 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-975725464
> Those metrics should be documented somehow.
IIRC, the consensus so far was to not document changelog at this stage; so the metrics shouldn't be mentioned in the docs either.
I think we could add documentation once we decide to make it visible for the users, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 643a25496b3c7ccce9f7c796a095fe5e5be83400 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315)
* f5498cd619035e5708a5bde18e0088ace9943d95 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* f5498cd619035e5708a5bde18e0088ace9943d95 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324)
* c81ce387e77568b32e16adb5a129e36a00a6bae9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
}, {
"hash" : "d2f18947342620d4e2573f5547385da72042b401",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864",
"triggerID" : "d2f18947342620d4e2573f5547385da72042b401",
"triggerType" : "PUSH"
}, {
"hash" : "6e7d0a992ca325e273d74c74e04d06da83622fbb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6e7d0a992ca325e273d74c74e04d06da83622fbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* d2f18947342620d4e2573f5547385da72042b401 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864)
* 6e7d0a992ca325e273d74c74e04d06da83622fbb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r754185342
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -123,12 +123,12 @@ public long getCount() {
}
private static final String PREFIX = "changelogStorage";
Review comment:
Sorry, misinterpreted your comment (thought you only propose to replace dashes).
Yes, I think this also makes sense, I'll change `"changelogStorage"` to `"ChangelogStorage"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
}, {
"hash" : "d2f18947342620d4e2573f5547385da72042b401",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d2f18947342620d4e2573f5547385da72042b401",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* a2470991a14803fe27df5e16ebf17becb8f36a40 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620)
* d2f18947342620d4e2573f5547385da72042b401 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
}, {
"hash" : "d2f18947342620d4e2573f5547385da72042b401",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864",
"triggerID" : "d2f18947342620d4e2573f5547385da72042b401",
"triggerType" : "PUSH"
}, {
"hash" : "6e7d0a992ca325e273d74c74e04d06da83622fbb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6e7d0a992ca325e273d74c74e04d06da83622fbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* d2f18947342620d4e2573f5547385da72042b401 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864)
* 6e7d0a992ca325e273d74c74e04d06da83622fbb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r755354905
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -134,6 +138,6 @@ public long getCount() {
PREFIX + ".uploadLatenciesNanos";
public static final String CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD =
PREFIX + ".attemptsPerUpload";
- public static final String CHANGELOG_STORAGE_LOGS_PER_UPLOAD = PREFIX + ".logsPerUpload";
+ public static final String CHANGELOG_STORAGE_UPLOAD_BATCH_SIZES = PREFIX + ".uploadBatchSizes";
Review comment:
Okay, I'll keep 'numberOfUploadRequests' and 'uploadBatchSizes'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-976898658
Thanks for the review!W
Build failure unrelated (FLINK-23525), private branch built successfully, merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* a0be72236b756fc85c2c6bd21900f276bfad7270 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422)
* 86a0e66fead48155e24a7aa4ad6b63e527e36f5d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* a0be72236b756fc85c2c6bd21900f276bfad7270 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r750375401
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
Review comment:
What's the problem here? That those metrics can be updated by many different threads? In opposite to the existing metrics, which are not thread safe, but updates are happening from a single thread?
(Our philosophy so far was that we prefer for metrics to be inaccurate rather then risk performance penalties for synchronisation)
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
+public class ChangelogStorageMetricGroup extends ProxyMetricGroup<MetricGroup> {
+ private static final int WINDOW_SIZE = 1000;
+
+ private final Counter uploadsCounter;
+ private final Counter uploadFailures;
+ private final Histogram logsPerUpload;
+ private final Histogram uploadSizes;
+ private final Histogram uploadLatencies;
+ private final Histogram attemptsPerUpload;
+
+ public ChangelogStorageMetricGroup(MetricGroup parent) {
+ super(parent);
+ this.uploadsCounter = counter(CHANGELOG_STORAGE_UPLOAD_REQUESTS, new ThreadSafeCounter());
+ this.logsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_LOGS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.attemptsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadSizes =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_SIZES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadLatencies =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_LATENCIES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadFailures = counter(CHANGELOG_STORAGE_UPLOAD_FAILURES, new ThreadSafeCounter());
+ }
+
+ public Counter getUploadsCounter() {
+ return uploadsCounter;
+ }
+
+ public Counter getFailuresCounter() {
+ return uploadFailures;
+ }
+
+ public Histogram getAttemptsPerUpload() {
+ return attemptsPerUpload;
+ }
+
+ public Histogram getLogsPerUpload() {
+ return logsPerUpload;
+ }
+
+ public Histogram getUploadSizes() {
+ return uploadSizes;
+ }
+
+ public Histogram getUploadLatencies() {
+ return uploadLatencies;
+ }
+
+ public void registerQueueSizeGauge(Gauge<Integer> gauge) {
+ gauge(CHANGELOG_STORAGE_QUEUE_SIZE, gauge);
+ }
+
+ private static class ThreadSafeCounter implements Counter {
+ private final LongAdder longAdder = new LongAdder();
+
+ @Override
+ public void inc() {
+ longAdder.increment();
+ }
+
+ @Override
+ public void inc(long n) {
+ longAdder.add(n);
+ }
+
+ @Override
+ public void dec() {
+ longAdder.decrement();
+ }
+
+ @Override
+ public void dec(long n) {
+ longAdder.add(-n);
+ }
+
+ @Override
+ public long getCount() {
+ return longAdder.longValue();
+ }
+ }
+
+ private static final String PREFIX = "changelogStorage";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX + ".upload-requests";
+ public static final String CHANGELOG_STORAGE_UPLOAD_FAILURES = PREFIX + ".upload-failures";
+ public static final String CHANGELOG_STORAGE_UPLOAD_SIZES = PREFIX + ".upload-sizes";
+ public static final String CHANGELOG_STORAGE_UPLOAD_LATENCIES = PREFIX + ".upload-latencies";
+ public static final String CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD =
+ PREFIX + ".attempts-per-upload";
+ public static final String CHANGELOG_STORAGE_LOGS_PER_UPLOAD = PREFIX + ".logs-per-upload";
+ public static final String CHANGELOG_STORAGE_QUEUE_SIZE = PREFIX + ".queue-size";
Review comment:
Wouldn't be
```
ChangelogStorage.lowerCamelCase
```
more consistent with the existing metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 86a0e66fead48155e24a7aa4ad6b63e527e36f5d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* f5498cd619035e5708a5bde18e0088ace9943d95 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324)
* c81ce387e77568b32e16adb5a129e36a00a6bae9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 643a25496b3c7ccce9f7c796a095fe5e5be83400 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315)
* f5498cd619035e5708a5bde18e0088ace9943d95 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 643a25496b3c7ccce9f7c796a095fe5e5be83400 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315)
* f5498cd619035e5708a5bde18e0088ace9943d95 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r754005566
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -123,12 +123,12 @@ public long getCount() {
}
private static final String PREFIX = "changelogStorage";
Review comment:
Bumping `ChangelogStorage` from the previous comment?
(This one I'm not sure what's or what should be our convention)
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/StateChangeFsUploader.java
##########
@@ -92,6 +103,16 @@ public void upload(Collection<UploadTask> tasks) throws IOException {
}
}
+ private LocalResult uploadWithMetrics(Path path, Collection<UploadTask> tasks)
+ throws IOException {
+ metrics.getUploadsCounter().inc();
+ long start = clock.relativeTimeNanos();
+ LocalResult result = upload(path, tasks);
+ metrics.getUploadLatencies().update(clock.relativeTimeNanos() - start);
Review comment:
Would it be better to have millis or nanos precision here?
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
+public class ChangelogStorageMetricGroup extends ProxyMetricGroup<MetricGroup> {
+ private static final int WINDOW_SIZE = 1000;
+
+ private final Counter uploadsCounter;
+ private final Counter uploadFailures;
+ private final Histogram logsPerUpload;
+ private final Histogram uploadSizes;
+ private final Histogram uploadLatencies;
+ private final Histogram attemptsPerUpload;
+
+ public ChangelogStorageMetricGroup(MetricGroup parent) {
+ super(parent);
+ this.uploadsCounter = counter(CHANGELOG_STORAGE_UPLOAD_REQUESTS, new ThreadSafeCounter());
+ this.logsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_LOGS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.attemptsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadSizes =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_SIZES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadLatencies =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_LATENCIES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadFailures = counter(CHANGELOG_STORAGE_UPLOAD_FAILURES, new ThreadSafeCounter());
+ }
+
+ public Counter getUploadsCounter() {
+ return uploadsCounter;
+ }
+
+ public Counter getFailuresCounter() {
+ return uploadFailures;
+ }
+
+ public Histogram getAttemptsPerUpload() {
+ return attemptsPerUpload;
+ }
+
+ public Histogram getLogsPerUpload() {
+ return logsPerUpload;
+ }
+
+ public Histogram getUploadSizes() {
+ return uploadSizes;
+ }
+
+ public Histogram getUploadLatencies() {
+ return uploadLatencies;
+ }
+
+ public void registerQueueSizeGauge(Gauge<Integer> gauge) {
+ gauge(CHANGELOG_STORAGE_QUEUE_SIZE, gauge);
+ }
+
+ private static class ThreadSafeCounter implements Counter {
+ private final LongAdder longAdder = new LongAdder();
+
+ @Override
+ public void inc() {
+ longAdder.increment();
+ }
+
+ @Override
+ public void inc(long n) {
+ longAdder.add(n);
+ }
+
+ @Override
+ public void dec() {
+ longAdder.decrement();
+ }
+
+ @Override
+ public void dec(long n) {
+ longAdder.add(-n);
+ }
+
+ @Override
+ public long getCount() {
+ return longAdder.longValue();
+ }
+ }
+
+ private static final String PREFIX = "changelogStorage";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX + ".uploadRequests";
Review comment:
`totalNumberOfUploadRequests`? `totalNumberOfUploads`?
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
+public class ChangelogStorageMetricGroup extends ProxyMetricGroup<MetricGroup> {
+ private static final int WINDOW_SIZE = 1000;
+
+ private final Counter uploadsCounter;
+ private final Counter uploadFailures;
+ private final Histogram logsPerUpload;
+ private final Histogram uploadSizes;
+ private final Histogram uploadLatencies;
+ private final Histogram attemptsPerUpload;
+
+ public ChangelogStorageMetricGroup(MetricGroup parent) {
+ super(parent);
+ this.uploadsCounter = counter(CHANGELOG_STORAGE_UPLOAD_REQUESTS, new ThreadSafeCounter());
+ this.logsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_LOGS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.attemptsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadSizes =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_SIZES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadLatencies =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_LATENCIES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadFailures = counter(CHANGELOG_STORAGE_UPLOAD_FAILURES, new ThreadSafeCounter());
+ }
+
+ public Counter getUploadsCounter() {
+ return uploadsCounter;
+ }
+
+ public Counter getFailuresCounter() {
+ return uploadFailures;
+ }
+
+ public Histogram getAttemptsPerUpload() {
+ return attemptsPerUpload;
+ }
+
+ public Histogram getLogsPerUpload() {
+ return logsPerUpload;
+ }
+
+ public Histogram getUploadSizes() {
+ return uploadSizes;
+ }
+
+ public Histogram getUploadLatencies() {
+ return uploadLatencies;
+ }
+
+ public void registerQueueSizeGauge(Gauge<Integer> gauge) {
+ gauge(CHANGELOG_STORAGE_QUEUE_SIZE, gauge);
+ }
+
+ private static class ThreadSafeCounter implements Counter {
+ private final LongAdder longAdder = new LongAdder();
+
+ @Override
+ public void inc() {
+ longAdder.increment();
+ }
+
+ @Override
+ public void inc(long n) {
+ longAdder.add(n);
+ }
+
+ @Override
+ public void dec() {
+ longAdder.decrement();
+ }
+
+ @Override
+ public void dec(long n) {
+ longAdder.add(-n);
+ }
+
+ @Override
+ public long getCount() {
+ return longAdder.longValue();
+ }
+ }
+
+ private static final String PREFIX = "changelogStorage";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX + ".uploadRequests";
+ public static final String CHANGELOG_STORAGE_UPLOAD_FAILURES = PREFIX + ".uploadFailures";
+ public static final String CHANGELOG_STORAGE_UPLOAD_SIZES = PREFIX + ".uploadSizes";
+ public static final String CHANGELOG_STORAGE_UPLOAD_LATENCIES = PREFIX + ".uploadLatencies";
+ public static final String CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD =
+ PREFIX + ".attemptsPerUpload";
+ public static final String CHANGELOG_STORAGE_LOGS_PER_UPLOAD = PREFIX + ".logsPerUpload";
+ public static final String CHANGELOG_STORAGE_QUEUE_SIZE = PREFIX + ".queueSize";
Review comment:
`currentUploadQueueSize`? `pendingUploads`? `numberOfPendingUploads`?
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
+public class ChangelogStorageMetricGroup extends ProxyMetricGroup<MetricGroup> {
+ private static final int WINDOW_SIZE = 1000;
+
+ private final Counter uploadsCounter;
+ private final Counter uploadFailures;
+ private final Histogram logsPerUpload;
+ private final Histogram uploadSizes;
+ private final Histogram uploadLatencies;
+ private final Histogram attemptsPerUpload;
+
+ public ChangelogStorageMetricGroup(MetricGroup parent) {
+ super(parent);
+ this.uploadsCounter = counter(CHANGELOG_STORAGE_UPLOAD_REQUESTS, new ThreadSafeCounter());
+ this.logsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_LOGS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.attemptsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadSizes =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_SIZES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadLatencies =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_LATENCIES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadFailures = counter(CHANGELOG_STORAGE_UPLOAD_FAILURES, new ThreadSafeCounter());
+ }
+
+ public Counter getUploadsCounter() {
+ return uploadsCounter;
+ }
+
+ public Counter getFailuresCounter() {
+ return uploadFailures;
+ }
+
+ public Histogram getAttemptsPerUpload() {
+ return attemptsPerUpload;
+ }
+
+ public Histogram getLogsPerUpload() {
+ return logsPerUpload;
+ }
+
+ public Histogram getUploadSizes() {
+ return uploadSizes;
+ }
+
+ public Histogram getUploadLatencies() {
+ return uploadLatencies;
+ }
+
+ public void registerQueueSizeGauge(Gauge<Integer> gauge) {
+ gauge(CHANGELOG_STORAGE_QUEUE_SIZE, gauge);
+ }
+
+ private static class ThreadSafeCounter implements Counter {
+ private final LongAdder longAdder = new LongAdder();
+
+ @Override
+ public void inc() {
+ longAdder.increment();
+ }
+
+ @Override
+ public void inc(long n) {
+ longAdder.add(n);
+ }
+
+ @Override
+ public void dec() {
+ longAdder.decrement();
+ }
+
+ @Override
+ public void dec(long n) {
+ longAdder.add(-n);
+ }
+
+ @Override
+ public long getCount() {
+ return longAdder.longValue();
+ }
+ }
+
+ private static final String PREFIX = "changelogStorage";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX + ".uploadRequests";
+ public static final String CHANGELOG_STORAGE_UPLOAD_FAILURES = PREFIX + ".uploadFailures";
+ public static final String CHANGELOG_STORAGE_UPLOAD_SIZES = PREFIX + ".uploadSizes";
+ public static final String CHANGELOG_STORAGE_UPLOAD_LATENCIES = PREFIX + ".uploadLatencies";
+ public static final String CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD =
+ PREFIX + ".attemptsPerUpload";
+ public static final String CHANGELOG_STORAGE_LOGS_PER_UPLOAD = PREFIX + ".logsPerUpload";
Review comment:
It's hard for me to deduce the meaning of this metric from this name? Can you either propose something more descriptive or explain for me what is the meaning of this metric?
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
+public class ChangelogStorageMetricGroup extends ProxyMetricGroup<MetricGroup> {
+ private static final int WINDOW_SIZE = 1000;
+
+ private final Counter uploadsCounter;
+ private final Counter uploadFailures;
+ private final Histogram logsPerUpload;
+ private final Histogram uploadSizes;
+ private final Histogram uploadLatencies;
+ private final Histogram attemptsPerUpload;
+
+ public ChangelogStorageMetricGroup(MetricGroup parent) {
+ super(parent);
+ this.uploadsCounter = counter(CHANGELOG_STORAGE_UPLOAD_REQUESTS, new ThreadSafeCounter());
+ this.logsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_LOGS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.attemptsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadSizes =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_SIZES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadLatencies =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_LATENCIES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadFailures = counter(CHANGELOG_STORAGE_UPLOAD_FAILURES, new ThreadSafeCounter());
+ }
+
+ public Counter getUploadsCounter() {
+ return uploadsCounter;
+ }
+
+ public Counter getFailuresCounter() {
+ return uploadFailures;
+ }
+
+ public Histogram getAttemptsPerUpload() {
+ return attemptsPerUpload;
+ }
+
+ public Histogram getLogsPerUpload() {
+ return logsPerUpload;
+ }
+
+ public Histogram getUploadSizes() {
+ return uploadSizes;
+ }
+
+ public Histogram getUploadLatencies() {
+ return uploadLatencies;
+ }
+
+ public void registerQueueSizeGauge(Gauge<Integer> gauge) {
+ gauge(CHANGELOG_STORAGE_QUEUE_SIZE, gauge);
+ }
+
+ private static class ThreadSafeCounter implements Counter {
+ private final LongAdder longAdder = new LongAdder();
+
+ @Override
+ public void inc() {
+ longAdder.increment();
+ }
+
+ @Override
+ public void inc(long n) {
+ longAdder.add(n);
+ }
+
+ @Override
+ public void dec() {
+ longAdder.decrement();
+ }
+
+ @Override
+ public void dec(long n) {
+ longAdder.add(-n);
+ }
+
+ @Override
+ public long getCount() {
+ return longAdder.longValue();
+ }
+ }
+
+ private static final String PREFIX = "changelogStorage";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX + ".uploadRequests";
+ public static final String CHANGELOG_STORAGE_UPLOAD_FAILURES = PREFIX + ".uploadFailures";
Review comment:
`numberOfUploadFailures`?
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -123,12 +123,12 @@ public long getCount() {
}
private static final String PREFIX = "changelogStorage";
- public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX + ".upload-requests";
- public static final String CHANGELOG_STORAGE_UPLOAD_FAILURES = PREFIX + ".upload-failures";
- public static final String CHANGELOG_STORAGE_UPLOAD_SIZES = PREFIX + ".upload-sizes";
- public static final String CHANGELOG_STORAGE_UPLOAD_LATENCIES = PREFIX + ".upload-latencies";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX + ".uploadRequests";
+ public static final String CHANGELOG_STORAGE_UPLOAD_FAILURES = PREFIX + ".uploadFailures";
+ public static final String CHANGELOG_STORAGE_UPLOAD_SIZES = PREFIX + ".uploadSizes";
+ public static final String CHANGELOG_STORAGE_UPLOAD_LATENCIES = PREFIX + ".uploadLatencies";
Review comment:
`uploadLatencies` -> `uploadLatenciesNanos` or `uploadLatenciesMs` (depending on another comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r754210678
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
+public class ChangelogStorageMetricGroup extends ProxyMetricGroup<MetricGroup> {
+ private static final int WINDOW_SIZE = 1000;
+
+ private final Counter uploadsCounter;
+ private final Counter uploadFailures;
+ private final Histogram logsPerUpload;
+ private final Histogram uploadSizes;
+ private final Histogram uploadLatencies;
+ private final Histogram attemptsPerUpload;
+
+ public ChangelogStorageMetricGroup(MetricGroup parent) {
+ super(parent);
+ this.uploadsCounter = counter(CHANGELOG_STORAGE_UPLOAD_REQUESTS, new ThreadSafeCounter());
+ this.logsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_LOGS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.attemptsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadSizes =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_SIZES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadLatencies =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_LATENCIES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadFailures = counter(CHANGELOG_STORAGE_UPLOAD_FAILURES, new ThreadSafeCounter());
+ }
+
+ public Counter getUploadsCounter() {
+ return uploadsCounter;
+ }
+
+ public Counter getFailuresCounter() {
+ return uploadFailures;
+ }
+
+ public Histogram getAttemptsPerUpload() {
+ return attemptsPerUpload;
+ }
+
+ public Histogram getLogsPerUpload() {
+ return logsPerUpload;
+ }
+
+ public Histogram getUploadSizes() {
+ return uploadSizes;
+ }
+
+ public Histogram getUploadLatencies() {
+ return uploadLatencies;
+ }
+
+ public void registerQueueSizeGauge(Gauge<Integer> gauge) {
+ gauge(CHANGELOG_STORAGE_QUEUE_SIZE, gauge);
+ }
+
+ private static class ThreadSafeCounter implements Counter {
+ private final LongAdder longAdder = new LongAdder();
+
+ @Override
+ public void inc() {
+ longAdder.increment();
+ }
+
+ @Override
+ public void inc(long n) {
+ longAdder.add(n);
+ }
+
+ @Override
+ public void dec() {
+ longAdder.decrement();
+ }
+
+ @Override
+ public void dec(long n) {
+ longAdder.add(-n);
+ }
+
+ @Override
+ public long getCount() {
+ return longAdder.longValue();
+ }
+ }
+
+ private static final String PREFIX = "changelogStorage";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX + ".uploadRequests";
Review comment:
WDYT about `numberOfUploadRequests`?
That would be more consistent with your comment below (`numberOfUploadFailures`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
}, {
"hash" : "d2f18947342620d4e2573f5547385da72042b401",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864",
"triggerID" : "d2f18947342620d4e2573f5547385da72042b401",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* d2f18947342620d4e2573f5547385da72042b401 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r754208421
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/StateChangeFsUploader.java
##########
@@ -92,6 +103,16 @@ public void upload(Collection<UploadTask> tasks) throws IOException {
}
}
+ private LocalResult uploadWithMetrics(Path path, Collection<UploadTask> tasks)
+ throws IOException {
+ metrics.getUploadsCounter().inc();
+ long start = clock.relativeTimeNanos();
+ LocalResult result = upload(path, tasks);
+ metrics.getUploadLatencies().update(clock.relativeTimeNanos() - start);
Review comment:
Is your question about a) `System.currentTimeMillis()` vs `System.nanoTime()` or b) whether nanos should be converted to milllis?
As for a), I think `currentTimeMillis` should NOT be used as it's not monotonic (I consider potential overhead of `nanoTime` is neglibible in context of IO)
As for b), I don't have a strong opinion. Nanosecond precision is consistent with State Backends latency tracking and potentially with future changelog implementations; it can also be useful in local setups (for debugging).
Division can be done closer to UI then if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan merged pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
rkhachatryan merged pull request #17757:
URL: https://github.com/apache/flink/pull/17757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
}, {
"hash" : "d2f18947342620d4e2573f5547385da72042b401",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864",
"triggerID" : "d2f18947342620d4e2573f5547385da72042b401",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* a2470991a14803fe27df5e16ebf17becb8f36a40 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620)
* d2f18947342620d4e2573f5547385da72042b401 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* a2470991a14803fe27df5e16ebf17becb8f36a40 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r754397298
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/StateChangeFsUploader.java
##########
@@ -92,6 +103,16 @@ public void upload(Collection<UploadTask> tasks) throws IOException {
}
}
+ private LocalResult uploadWithMetrics(Path path, Collection<UploadTask> tasks)
+ throws IOException {
+ metrics.getUploadsCounter().inc();
+ long start = clock.relativeTimeNanos();
+ LocalResult result = upload(path, tasks);
+ metrics.getUploadLatencies().update(clock.relativeTimeNanos() - start);
Review comment:
I was asking about how to present this value to the users (webUI/metric reporters/logs/...) (so, `b)`). Indeed maybe nanos is a bit better here, "just in case we need this extra precision in the future".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* f5498cd619035e5708a5bde18e0088ace9943d95 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* c81ce387e77568b32e16adb5a129e36a00a6bae9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* f5498cd619035e5708a5bde18e0088ace9943d95 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324)
* c81ce387e77568b32e16adb5a129e36a00a6bae9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* a0be72236b756fc85c2c6bd21900f276bfad7270 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422)
* 86a0e66fead48155e24a7aa4ad6b63e527e36f5d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-970687649
Build failure unrelated: FLINK-16908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
}, {
"hash" : "d2f18947342620d4e2573f5547385da72042b401",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d2f18947342620d4e2573f5547385da72042b401",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* a2470991a14803fe27df5e16ebf17becb8f36a40 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620)
* d2f18947342620d4e2573f5547385da72042b401 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r754450587
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
+public class ChangelogStorageMetricGroup extends ProxyMetricGroup<MetricGroup> {
+ private static final int WINDOW_SIZE = 1000;
+
+ private final Counter uploadsCounter;
+ private final Counter uploadFailures;
+ private final Histogram logsPerUpload;
+ private final Histogram uploadSizes;
+ private final Histogram uploadLatencies;
+ private final Histogram attemptsPerUpload;
+
+ public ChangelogStorageMetricGroup(MetricGroup parent) {
+ super(parent);
+ this.uploadsCounter = counter(CHANGELOG_STORAGE_UPLOAD_REQUESTS, new ThreadSafeCounter());
+ this.logsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_LOGS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.attemptsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadSizes =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_SIZES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadLatencies =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_LATENCIES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadFailures = counter(CHANGELOG_STORAGE_UPLOAD_FAILURES, new ThreadSafeCounter());
+ }
+
+ public Counter getUploadsCounter() {
+ return uploadsCounter;
+ }
+
+ public Counter getFailuresCounter() {
+ return uploadFailures;
+ }
+
+ public Histogram getAttemptsPerUpload() {
+ return attemptsPerUpload;
+ }
+
+ public Histogram getLogsPerUpload() {
+ return logsPerUpload;
+ }
+
+ public Histogram getUploadSizes() {
+ return uploadSizes;
+ }
+
+ public Histogram getUploadLatencies() {
+ return uploadLatencies;
+ }
+
+ public void registerQueueSizeGauge(Gauge<Integer> gauge) {
+ gauge(CHANGELOG_STORAGE_QUEUE_SIZE, gauge);
+ }
+
+ private static class ThreadSafeCounter implements Counter {
+ private final LongAdder longAdder = new LongAdder();
+
+ @Override
+ public void inc() {
+ longAdder.increment();
+ }
+
+ @Override
+ public void inc(long n) {
+ longAdder.add(n);
+ }
+
+ @Override
+ public void dec() {
+ longAdder.decrement();
+ }
+
+ @Override
+ public void dec(long n) {
+ longAdder.add(-n);
+ }
+
+ @Override
+ public long getCount() {
+ return longAdder.longValue();
+ }
+ }
+
+ private static final String PREFIX = "changelogStorage";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX + ".uploadRequests";
+ public static final String CHANGELOG_STORAGE_UPLOAD_FAILURES = PREFIX + ".uploadFailures";
+ public static final String CHANGELOG_STORAGE_UPLOAD_SIZES = PREFIX + ".uploadSizes";
+ public static final String CHANGELOG_STORAGE_UPLOAD_LATENCIES = PREFIX + ".uploadLatencies";
+ public static final String CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD =
+ PREFIX + ".attemptsPerUpload";
+ public static final String CHANGELOG_STORAGE_LOGS_PER_UPLOAD = PREFIX + ".logsPerUpload";
Review comment:
I agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
}, {
"hash" : "d2f18947342620d4e2573f5547385da72042b401",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864",
"triggerID" : "d2f18947342620d4e2573f5547385da72042b401",
"triggerType" : "PUSH"
}, {
"hash" : "6e7d0a992ca325e273d74c74e04d06da83622fbb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26929",
"triggerID" : "6e7d0a992ca325e273d74c74e04d06da83622fbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 6e7d0a992ca325e273d74c74e04d06da83622fbb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26929)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* c81ce387e77568b32e16adb5a129e36a00a6bae9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361)
* a0be72236b756fc85c2c6bd21900f276bfad7270 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 643a25496b3c7ccce9f7c796a095fe5e5be83400 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* a0be72236b756fc85c2c6bd21900f276bfad7270 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2db1ab776228ba573da1b098ef6692de3b583323 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* c81ce387e77568b32e16adb5a129e36a00a6bae9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361)
* a0be72236b756fc85c2c6bd21900f276bfad7270 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* c81ce387e77568b32e16adb5a129e36a00a6bae9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* c81ce387e77568b32e16adb5a129e36a00a6bae9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361)
* a0be72236b756fc85c2c6bd21900f276bfad7270 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965291936
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 2db1ab776228ba573da1b098ef6692de3b583323 (Wed Nov 10 14:38:57 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
}, {
"hash" : "d2f18947342620d4e2573f5547385da72042b401",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d2f18947342620d4e2573f5547385da72042b401",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* a2470991a14803fe27df5e16ebf17becb8f36a40 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620)
* d2f18947342620d4e2573f5547385da72042b401 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r754477778
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -134,6 +138,6 @@ public long getCount() {
PREFIX + ".uploadLatenciesNanos";
public static final String CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD =
PREFIX + ".attemptsPerUpload";
- public static final String CHANGELOG_STORAGE_LOGS_PER_UPLOAD = PREFIX + ".logsPerUpload";
+ public static final String CHANGELOG_STORAGE_UPLOAD_BATCH_SIZES = PREFIX + ".uploadBatchSizes";
Review comment:
The word "request" is already used in sense "request to DFS" (`numberOfUploadRequests` as discussed above).
But maybe we should have
- `numberOfUploadRequests` -> `numberOfUploads`
- `uploadBatchSizes` -> `incomingRequestsPerUpload` or `incomingRequestsPerBatch`
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-975660963
Those metrics should be documented somehow. Do we already have a place to do that? I presume the overall `metrics.md` might not be the best place, and a better one would be a dedicated changelog statebackend doc page, with only a pointer from `metrics.md` to this dedicated page/section?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
}, {
"hash" : "d2f18947342620d4e2573f5547385da72042b401",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864",
"triggerID" : "d2f18947342620d4e2573f5547385da72042b401",
"triggerType" : "PUSH"
}, {
"hash" : "6e7d0a992ca325e273d74c74e04d06da83622fbb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6e7d0a992ca325e273d74c74e04d06da83622fbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* d2f18947342620d4e2573f5547385da72042b401 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864)
* 6e7d0a992ca325e273d74c74e04d06da83622fbb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
}, {
"hash" : "d2f18947342620d4e2573f5547385da72042b401",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864",
"triggerID" : "d2f18947342620d4e2573f5547385da72042b401",
"triggerType" : "PUSH"
}, {
"hash" : "6e7d0a992ca325e273d74c74e04d06da83622fbb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6e7d0a992ca325e273d74c74e04d06da83622fbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* d2f18947342620d4e2573f5547385da72042b401 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864)
* 6e7d0a992ca325e273d74c74e04d06da83622fbb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* a0be72236b756fc85c2c6bd21900f276bfad7270 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422)
* 86a0e66fead48155e24a7aa4ad6b63e527e36f5d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* a2470991a14803fe27df5e16ebf17becb8f36a40 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 86a0e66fead48155e24a7aa4ad6b63e527e36f5d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593)
* a2470991a14803fe27df5e16ebf17becb8f36a40 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 86a0e66fead48155e24a7aa4ad6b63e527e36f5d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593)
* a2470991a14803fe27df5e16ebf17becb8f36a40 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* c81ce387e77568b32e16adb5a129e36a00a6bae9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361)
* a0be72236b756fc85c2c6bd21900f276bfad7270 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* f5498cd619035e5708a5bde18e0088ace9943d95 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2db1ab776228ba573da1b098ef6692de3b583323 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305)
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* f5498cd619035e5708a5bde18e0088ace9943d95 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324)
* c81ce387e77568b32e16adb5a129e36a00a6bae9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
}, {
"hash" : "d2f18947342620d4e2573f5547385da72042b401",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864",
"triggerID" : "d2f18947342620d4e2573f5547385da72042b401",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* d2f18947342620d4e2573f5547385da72042b401 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
}, {
"hash" : "d2f18947342620d4e2573f5547385da72042b401",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864",
"triggerID" : "d2f18947342620d4e2573f5547385da72042b401",
"triggerType" : "PUSH"
}, {
"hash" : "6e7d0a992ca325e273d74c74e04d06da83622fbb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26929",
"triggerID" : "6e7d0a992ca325e273d74c74e04d06da83622fbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* d2f18947342620d4e2573f5547385da72042b401 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864)
* 6e7d0a992ca325e273d74c74e04d06da83622fbb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26929)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r754214917
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
+public class ChangelogStorageMetricGroup extends ProxyMetricGroup<MetricGroup> {
+ private static final int WINDOW_SIZE = 1000;
+
+ private final Counter uploadsCounter;
+ private final Counter uploadFailures;
+ private final Histogram logsPerUpload;
+ private final Histogram uploadSizes;
+ private final Histogram uploadLatencies;
+ private final Histogram attemptsPerUpload;
+
+ public ChangelogStorageMetricGroup(MetricGroup parent) {
+ super(parent);
+ this.uploadsCounter = counter(CHANGELOG_STORAGE_UPLOAD_REQUESTS, new ThreadSafeCounter());
+ this.logsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_LOGS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.attemptsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadSizes =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_SIZES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadLatencies =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_LATENCIES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadFailures = counter(CHANGELOG_STORAGE_UPLOAD_FAILURES, new ThreadSafeCounter());
+ }
+
+ public Counter getUploadsCounter() {
+ return uploadsCounter;
+ }
+
+ public Counter getFailuresCounter() {
+ return uploadFailures;
+ }
+
+ public Histogram getAttemptsPerUpload() {
+ return attemptsPerUpload;
+ }
+
+ public Histogram getLogsPerUpload() {
+ return logsPerUpload;
+ }
+
+ public Histogram getUploadSizes() {
+ return uploadSizes;
+ }
+
+ public Histogram getUploadLatencies() {
+ return uploadLatencies;
+ }
+
+ public void registerQueueSizeGauge(Gauge<Integer> gauge) {
+ gauge(CHANGELOG_STORAGE_QUEUE_SIZE, gauge);
+ }
+
+ private static class ThreadSafeCounter implements Counter {
+ private final LongAdder longAdder = new LongAdder();
+
+ @Override
+ public void inc() {
+ longAdder.increment();
+ }
+
+ @Override
+ public void inc(long n) {
+ longAdder.add(n);
+ }
+
+ @Override
+ public void dec() {
+ longAdder.decrement();
+ }
+
+ @Override
+ public void dec(long n) {
+ longAdder.add(-n);
+ }
+
+ @Override
+ public long getCount() {
+ return longAdder.longValue();
+ }
+ }
+
+ private static final String PREFIX = "changelogStorage";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX + ".uploadRequests";
+ public static final String CHANGELOG_STORAGE_UPLOAD_FAILURES = PREFIX + ".uploadFailures";
+ public static final String CHANGELOG_STORAGE_UPLOAD_SIZES = PREFIX + ".uploadSizes";
+ public static final String CHANGELOG_STORAGE_UPLOAD_LATENCIES = PREFIX + ".uploadLatencies";
+ public static final String CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD =
+ PREFIX + ".attemptsPerUpload";
+ public static final String CHANGELOG_STORAGE_LOGS_PER_UPLOAD = PREFIX + ".logsPerUpload";
Review comment:
This is the number of upload tasks (coming from one or more writers, i.e. backends/tasks) that were grouped together and form a single upload and result in a single file.
WDYT about `uploadGroupSizes` or `uploadBatchSizes` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r754470187
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -134,6 +138,6 @@ public long getCount() {
PREFIX + ".uploadLatenciesNanos";
public static final String CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD =
PREFIX + ".attemptsPerUpload";
- public static final String CHANGELOG_STORAGE_LOGS_PER_UPLOAD = PREFIX + ".logsPerUpload";
+ public static final String CHANGELOG_STORAGE_UPLOAD_BATCH_SIZES = PREFIX + ".uploadBatchSizes";
Review comment:
Hmmm, nit: maybe `numberOfRequestsPerBatch`? `uploadRequestsPerBatch`? uploadRequestsInBatch`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* a2470991a14803fe27df5e16ebf17becb8f36a40 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r754218298
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
+public class ChangelogStorageMetricGroup extends ProxyMetricGroup<MetricGroup> {
+ private static final int WINDOW_SIZE = 1000;
+
+ private final Counter uploadsCounter;
+ private final Counter uploadFailures;
+ private final Histogram logsPerUpload;
+ private final Histogram uploadSizes;
+ private final Histogram uploadLatencies;
+ private final Histogram attemptsPerUpload;
+
+ public ChangelogStorageMetricGroup(MetricGroup parent) {
+ super(parent);
+ this.uploadsCounter = counter(CHANGELOG_STORAGE_UPLOAD_REQUESTS, new ThreadSafeCounter());
+ this.logsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_LOGS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.attemptsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadSizes =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_SIZES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadLatencies =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_LATENCIES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadFailures = counter(CHANGELOG_STORAGE_UPLOAD_FAILURES, new ThreadSafeCounter());
+ }
+
+ public Counter getUploadsCounter() {
+ return uploadsCounter;
+ }
+
+ public Counter getFailuresCounter() {
+ return uploadFailures;
+ }
+
+ public Histogram getAttemptsPerUpload() {
+ return attemptsPerUpload;
+ }
+
+ public Histogram getLogsPerUpload() {
+ return logsPerUpload;
+ }
+
+ public Histogram getUploadSizes() {
+ return uploadSizes;
+ }
+
+ public Histogram getUploadLatencies() {
+ return uploadLatencies;
+ }
+
+ public void registerQueueSizeGauge(Gauge<Integer> gauge) {
+ gauge(CHANGELOG_STORAGE_QUEUE_SIZE, gauge);
+ }
+
+ private static class ThreadSafeCounter implements Counter {
+ private final LongAdder longAdder = new LongAdder();
+
+ @Override
+ public void inc() {
+ longAdder.increment();
+ }
+
+ @Override
+ public void inc(long n) {
+ longAdder.add(n);
+ }
+
+ @Override
+ public void dec() {
+ longAdder.decrement();
+ }
+
+ @Override
+ public void dec(long n) {
+ longAdder.add(-n);
+ }
+
+ @Override
+ public long getCount() {
+ return longAdder.longValue();
+ }
+ }
+
+ private static final String PREFIX = "changelogStorage";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX + ".uploadRequests";
+ public static final String CHANGELOG_STORAGE_UPLOAD_FAILURES = PREFIX + ".uploadFailures";
+ public static final String CHANGELOG_STORAGE_UPLOAD_SIZES = PREFIX + ".uploadSizes";
+ public static final String CHANGELOG_STORAGE_UPLOAD_LATENCIES = PREFIX + ".uploadLatencies";
+ public static final String CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD =
+ PREFIX + ".attemptsPerUpload";
+ public static final String CHANGELOG_STORAGE_LOGS_PER_UPLOAD = PREFIX + ".logsPerUpload";
+ public static final String CHANGELOG_STORAGE_QUEUE_SIZE = PREFIX + ".queueSize";
Review comment:
"Pending" seems ambiguous to me because uploads to retry and pre-emptive data to upload can also be called as such.
And "current" seems redundant, how about `uploadQueueSize`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 643a25496b3c7ccce9f7c796a095fe5e5be83400 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315)
* f5498cd619035e5708a5bde18e0088ace9943d95 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* c81ce387e77568b32e16adb5a129e36a00a6bae9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 643a25496b3c7ccce9f7c796a095fe5e5be83400 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* a0be72236b756fc85c2c6bd21900f276bfad7270 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422)
* 86a0e66fead48155e24a7aa4ad6b63e527e36f5d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 86a0e66fead48155e24a7aa4ad6b63e527e36f5d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r755354905
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -134,6 +138,6 @@ public long getCount() {
PREFIX + ".uploadLatenciesNanos";
public static final String CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD =
PREFIX + ".attemptsPerUpload";
- public static final String CHANGELOG_STORAGE_LOGS_PER_UPLOAD = PREFIX + ".logsPerUpload";
+ public static final String CHANGELOG_STORAGE_UPLOAD_BATCH_SIZES = PREFIX + ".uploadBatchSizes";
Review comment:
Okay, I'll keep `numberOfUploadRequests` and `uploadBatchSizes`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r754444136
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
+public class ChangelogStorageMetricGroup extends ProxyMetricGroup<MetricGroup> {
+ private static final int WINDOW_SIZE = 1000;
+
+ private final Counter uploadsCounter;
+ private final Counter uploadFailures;
+ private final Histogram logsPerUpload;
+ private final Histogram uploadSizes;
+ private final Histogram uploadLatencies;
+ private final Histogram attemptsPerUpload;
+
+ public ChangelogStorageMetricGroup(MetricGroup parent) {
+ super(parent);
+ this.uploadsCounter = counter(CHANGELOG_STORAGE_UPLOAD_REQUESTS, new ThreadSafeCounter());
+ this.logsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_LOGS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.attemptsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadSizes =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_SIZES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadLatencies =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_LATENCIES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadFailures = counter(CHANGELOG_STORAGE_UPLOAD_FAILURES, new ThreadSafeCounter());
+ }
+
+ public Counter getUploadsCounter() {
+ return uploadsCounter;
+ }
+
+ public Counter getFailuresCounter() {
+ return uploadFailures;
+ }
+
+ public Histogram getAttemptsPerUpload() {
+ return attemptsPerUpload;
+ }
+
+ public Histogram getLogsPerUpload() {
+ return logsPerUpload;
+ }
+
+ public Histogram getUploadSizes() {
+ return uploadSizes;
+ }
+
+ public Histogram getUploadLatencies() {
+ return uploadLatencies;
+ }
+
+ public void registerQueueSizeGauge(Gauge<Integer> gauge) {
+ gauge(CHANGELOG_STORAGE_QUEUE_SIZE, gauge);
+ }
+
+ private static class ThreadSafeCounter implements Counter {
+ private final LongAdder longAdder = new LongAdder();
+
+ @Override
+ public void inc() {
+ longAdder.increment();
+ }
+
+ @Override
+ public void inc(long n) {
+ longAdder.add(n);
+ }
+
+ @Override
+ public void dec() {
+ longAdder.decrement();
+ }
+
+ @Override
+ public void dec(long n) {
+ longAdder.add(-n);
+ }
+
+ @Override
+ public long getCount() {
+ return longAdder.longValue();
+ }
+ }
+
+ private static final String PREFIX = "changelogStorage";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX + ".uploadRequests";
Review comment:
I see. I think `numberOfUploadRequests` is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r755278167
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -134,6 +138,6 @@ public long getCount() {
PREFIX + ".uploadLatenciesNanos";
public static final String CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD =
PREFIX + ".attemptsPerUpload";
- public static final String CHANGELOG_STORAGE_LOGS_PER_UPLOAD = PREFIX + ".logsPerUpload";
+ public static final String CHANGELOG_STORAGE_UPLOAD_BATCH_SIZES = PREFIX + ".uploadBatchSizes";
Review comment:
Good point. In that case I would keep `numberOfUploadRequests`, and use here either `uploadBatchSizes` (it's I think ok after all) or `numberOfUpdatesPerBatch`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r754214917
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
+public class ChangelogStorageMetricGroup extends ProxyMetricGroup<MetricGroup> {
+ private static final int WINDOW_SIZE = 1000;
+
+ private final Counter uploadsCounter;
+ private final Counter uploadFailures;
+ private final Histogram logsPerUpload;
+ private final Histogram uploadSizes;
+ private final Histogram uploadLatencies;
+ private final Histogram attemptsPerUpload;
+
+ public ChangelogStorageMetricGroup(MetricGroup parent) {
+ super(parent);
+ this.uploadsCounter = counter(CHANGELOG_STORAGE_UPLOAD_REQUESTS, new ThreadSafeCounter());
+ this.logsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_LOGS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.attemptsPerUpload =
+ histogram(
+ CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadSizes =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_SIZES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadLatencies =
+ histogram(
+ CHANGELOG_STORAGE_UPLOAD_LATENCIES,
+ new DescriptiveStatisticsHistogram(WINDOW_SIZE));
+ this.uploadFailures = counter(CHANGELOG_STORAGE_UPLOAD_FAILURES, new ThreadSafeCounter());
+ }
+
+ public Counter getUploadsCounter() {
+ return uploadsCounter;
+ }
+
+ public Counter getFailuresCounter() {
+ return uploadFailures;
+ }
+
+ public Histogram getAttemptsPerUpload() {
+ return attemptsPerUpload;
+ }
+
+ public Histogram getLogsPerUpload() {
+ return logsPerUpload;
+ }
+
+ public Histogram getUploadSizes() {
+ return uploadSizes;
+ }
+
+ public Histogram getUploadLatencies() {
+ return uploadLatencies;
+ }
+
+ public void registerQueueSizeGauge(Gauge<Integer> gauge) {
+ gauge(CHANGELOG_STORAGE_QUEUE_SIZE, gauge);
+ }
+
+ private static class ThreadSafeCounter implements Counter {
+ private final LongAdder longAdder = new LongAdder();
+
+ @Override
+ public void inc() {
+ longAdder.increment();
+ }
+
+ @Override
+ public void inc(long n) {
+ longAdder.add(n);
+ }
+
+ @Override
+ public void dec() {
+ longAdder.decrement();
+ }
+
+ @Override
+ public void dec(long n) {
+ longAdder.add(-n);
+ }
+
+ @Override
+ public long getCount() {
+ return longAdder.longValue();
+ }
+ }
+
+ private static final String PREFIX = "changelogStorage";
+ public static final String CHANGELOG_STORAGE_UPLOAD_REQUESTS = PREFIX + ".uploadRequests";
+ public static final String CHANGELOG_STORAGE_UPLOAD_FAILURES = PREFIX + ".uploadFailures";
+ public static final String CHANGELOG_STORAGE_UPLOAD_SIZES = PREFIX + ".uploadSizes";
+ public static final String CHANGELOG_STORAGE_UPLOAD_LATENCIES = PREFIX + ".uploadLatencies";
+ public static final String CHANGELOG_STORAGE_ATTEMPTS_PER_UPLOAD =
+ PREFIX + ".attemptsPerUpload";
+ public static final String CHANGELOG_STORAGE_LOGS_PER_UPLOAD = PREFIX + ".logsPerUpload";
Review comment:
This is the number of upload tasks (coming from one or more writers, i.e. backends/tasks) that were grouped together and form a single upload and result in a single file.
WDYT about `uploadGroupSize` or `uploadBatchSize` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
}, {
"hash" : "d2f18947342620d4e2573f5547385da72042b401",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864",
"triggerID" : "d2f18947342620d4e2573f5547385da72042b401",
"triggerType" : "PUSH"
}, {
"hash" : "6e7d0a992ca325e273d74c74e04d06da83622fbb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6e7d0a992ca325e273d74c74e04d06da83622fbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* d2f18947342620d4e2573f5547385da72042b401 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864)
* 6e7d0a992ca325e273d74c74e04d06da83622fbb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r754397298
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/StateChangeFsUploader.java
##########
@@ -92,6 +103,16 @@ public void upload(Collection<UploadTask> tasks) throws IOException {
}
}
+ private LocalResult uploadWithMetrics(Path path, Collection<UploadTask> tasks)
+ throws IOException {
+ metrics.getUploadsCounter().inc();
+ long start = clock.relativeTimeNanos();
+ LocalResult result = upload(path, tasks);
+ metrics.getUploadLatencies().update(clock.relativeTimeNanos() - start);
Review comment:
I was asking about how to present this value to the users (webUI/metric reporters/logs/...). Indeed maybe nanos is a bit better here, "just in case we need this extra precision in the future".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26620",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
}, {
"hash" : "d2f18947342620d4e2573f5547385da72042b401",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864",
"triggerID" : "d2f18947342620d4e2573f5547385da72042b401",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* d2f18947342620d4e2573f5547385da72042b401 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26864)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 643a25496b3c7ccce9f7c796a095fe5e5be83400 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315)
* f5498cd619035e5708a5bde18e0088ace9943d95 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2db1ab776228ba573da1b098ef6692de3b583323 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305)
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 643a25496b3c7ccce9f7c796a095fe5e5be83400 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 643a25496b3c7ccce9f7c796a095fe5e5be83400 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 643a25496b3c7ccce9f7c796a095fe5e5be83400 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2db1ab776228ba573da1b098ef6692de3b583323 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 643a25496b3c7ccce9f7c796a095fe5e5be83400 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315)
* f5498cd619035e5708a5bde18e0088ace9943d95 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 643a25496b3c7ccce9f7c796a095fe5e5be83400 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* c81ce387e77568b32e16adb5a129e36a00a6bae9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361)
* a0be72236b756fc85c2c6bd21900f276bfad7270 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* f5498cd619035e5708a5bde18e0088ace9943d95 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324)
* c81ce387e77568b32e16adb5a129e36a00a6bae9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* f5498cd619035e5708a5bde18e0088ace9943d95 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 86a0e66fead48155e24a7aa4ad6b63e527e36f5d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 86a0e66fead48155e24a7aa4ad6b63e527e36f5d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593)
* a2470991a14803fe27df5e16ebf17becb8f36a40 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 86a0e66fead48155e24a7aa4ad6b63e527e36f5d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593)
* a2470991a14803fe27df5e16ebf17becb8f36a40 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 86a0e66fead48155e24a7aa4ad6b63e527e36f5d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #17757:
URL: https://github.com/apache/flink/pull/17757#discussion_r750487411
##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.changelog.fs;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.DescriptiveStatisticsHistogram;
+import org.apache.flink.runtime.metrics.groups.ProxyMetricGroup;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import java.util.concurrent.atomic.LongAdder;
+
+/**
+ * Metrics related to the Changelog Storage used by the Changelog State Backend. Thread-safety is
+ * required because it is used by multiple uploader threads.
+ */
+@ThreadSafe
Review comment:
Exactly, Thread-safety is required because it is used by multiple uploader threads.
Let me clarify first:
- existing metric **groups** are thread-safe (though they don't have to be, just by convention)
- the metrics they register are usually not (depends on the implementation, e.g. histogram is thread-safe)
Now, the existing metrics are usually updated by one thread and read by another, so in the worst case results will be delayed.
But here, metrics are **updated** by multiple threads; so results could be corrupted if not thread-safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17757:
URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26072",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "2db1ab776228ba573da1b098ef6692de3b583323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26305",
"triggerID" : "2db1ab776228ba573da1b098ef6692de3b583323",
"triggerType" : "PUSH"
}, {
"hash" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3800ed083f10e70c10de50c1f77c2bd41c116a",
"triggerType" : "PUSH"
}, {
"hash" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26315",
"triggerID" : "643a25496b3c7ccce9f7c796a095fe5e5be83400",
"triggerType" : "PUSH"
}, {
"hash" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26324",
"triggerID" : "f5498cd619035e5708a5bde18e0088ace9943d95",
"triggerType" : "PUSH"
}, {
"hash" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26361",
"triggerID" : "c81ce387e77568b32e16adb5a129e36a00a6bae9",
"triggerType" : "PUSH"
}, {
"hash" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26422",
"triggerID" : "a0be72236b756fc85c2c6bd21900f276bfad7270",
"triggerType" : "PUSH"
}, {
"hash" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593",
"triggerID" : "86a0e66fead48155e24a7aa4ad6b63e527e36f5d",
"triggerType" : "PUSH"
}, {
"hash" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a2470991a14803fe27df5e16ebf17becb8f36a40",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN
* 86a0e66fead48155e24a7aa4ad6b63e527e36f5d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26593)
* a2470991a14803fe27df5e16ebf17becb8f36a40 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org