[GitHub] sijie closed pull request #1082: Issue 1079: use CachingStatsProvider underly FinagleStatsProvider

[GitBox <gi...@apache.org>]

sijie closed pull request #1082: Issue 1079: use CachingStatsProvider underly FinagleStatsProvider
URL: https://github.com/apache/bookkeeper/pull/1082
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bookkeeper-stats-providers/twitter-finagle-provider/src/main/java/org/apache/bookkeeper/stats/twitter/finagle/FinagleStatsProvider.java b/bookkeeper-stats-providers/twitter-finagle-provider/src/main/java/org/apache/bookkeeper/stats/twitter/finagle/FinagleStatsProvider.java
index affe2f978..aff129d98 100644
--- a/bookkeeper-stats-providers/twitter-finagle-provider/src/main/java/org/apache/bookkeeper/stats/twitter/finagle/FinagleStatsProvider.java
+++ b/bookkeeper-stats-providers/twitter-finagle-provider/src/main/java/org/apache/bookkeeper/stats/twitter/finagle/FinagleStatsProvider.java
@@ -18,6 +18,7 @@
 package org.apache.bookkeeper.stats.twitter.finagle;
 
 import com.twitter.finagle.stats.StatsReceiver;
+import org.apache.bookkeeper.stats.CachingStatsProvider;
 import org.apache.bookkeeper.stats.StatsLogger;
 import org.apache.bookkeeper.stats.StatsProvider;
 import org.apache.commons.configuration.Configuration;
@@ -29,9 +30,28 @@
  */
 public class FinagleStatsProvider implements StatsProvider {
     private final StatsReceiver stats;
+    private final CachingStatsProvider cachingStatsProvider;
 
     public FinagleStatsProvider(final StatsReceiver stats) {
         this.stats = stats;
+        this.cachingStatsProvider = new CachingStatsProvider(
+            new StatsProvider() {
+                @Override
+                public void start(Configuration conf) {
+                    // nop
+                }
+
+                @Override
+                public void stop() {
+                    // nop
+                }
+
+                @Override
+                public StatsLogger getStatsLogger(String scope) {
+                    return new FinagleStatsLoggerImpl(stats.scope(scope));
+                }
+            }
+        );
     }
 
     @Override
@@ -42,6 +62,6 @@ public void stop() { /* no-op */ }
 
     @Override
     public StatsLogger getStatsLogger(final String scope) {
-        return new FinagleStatsLoggerImpl(this.stats.scope(scope));
+        return this.cachingStatsProvider.getStatsLogger(scope);
     }
 }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services