You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/15 21:41:12 UTC

[GitHub] [pulsar] oliverisaac opened a new issue, #17678: Broker metrics on `/metrics/` not `/metrics` [Doc]

oliverisaac opened a new issue, #17678:
URL: https://github.com/apache/pulsar/issues/17678

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
   
   
   ### What issue do you find in Pulsar docs?
   
   The broker metrics are behind `/metrics/` _not_ `/metrics` as documented. (Not the trailing slash.)
   
   ### What is your suggestion?
   
   Update docs (for all versions) to reflect the trailing slash.
   
   Would also be nice to fix this so that `/metrics` and `/metrics/` both work.
   
   ### Any reference?
   
   https://pulsar.apache.org/docs/reference-metrics/#broker
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on issue #17678: Broker metrics on `/metrics/` not `/metrics` [Doc]

Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #17678:
URL: https://github.com/apache/pulsar/issues/17678#issuecomment-1248863523

   @oliverisaac I try `localhost:8080/metrics` and the browser automatically directs me to http://localhost:8080/metrics and returns the correct result. This manner should be fine to me.
   
   Do you encounter a case that 404 or other critical error when open `/metrics`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] oliverisaac closed issue #17678: Broker metrics on `/metrics/` not `/metrics` [Doc]

Posted by GitBox <gi...@apache.org>.
oliverisaac closed issue #17678: Broker metrics on `/metrics/` not `/metrics` [Doc]
URL: https://github.com/apache/pulsar/issues/17678


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on issue #17678: Broker metrics on `/metrics/` not `/metrics` [Doc]

Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #17678:
URL: https://github.com/apache/pulsar/issues/17678#issuecomment-1248842563

   Generally, the trailing slash should be able to omit. It may not a doc issue but less than awesome software experience :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on issue #17678: Broker metrics on `/metrics/` not `/metrics` [Doc]

Posted by GitBox <gi...@apache.org>.
momo-jun commented on issue #17678:
URL: https://github.com/apache/pulsar/issues/17678#issuecomment-1248841420

   @tjiuming can you pls take a look at this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] oliverisaac commented on issue #17678: Broker metrics on `/metrics/` not `/metrics` [Doc]

Posted by GitBox <gi...@apache.org>.
oliverisaac commented on issue #17678:
URL: https://github.com/apache/pulsar/issues/17678#issuecomment-1249358525

   Ah, yes! That endpoint returns a 302 and it didn't occur to me to try the `curl -L`! 🤦‍♂️ 
   
   > It may not a doc issue but less than awesome software experience 
   
   I'm going to close this issue as, technically, `/metrics` works even though the metrics are "actaully" at `/metrics/`. On the other hand, having to do `curl -L` instead of just a `curl` probably falls under the "less than awesome software experience" umbrella. 🤷‍♂️ 
   
   Thanks for the quick response! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org