[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add to_json in FunctionRegistr...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16981#discussion_r104090730
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonUtils.scala ---
    @@ -55,4 +60,22 @@ object JacksonUtils {
     
         schema.foreach(field => verifyType(field.name, field.dataType))
       }
    +
    +  def strToStructType(schemaAsJson: String): StructType = Try {
    +    DataType.fromJson(schemaAsJson).asInstanceOf[StructType]
    +  }.getOrElse {
    --- End diff --
    
    > prefer explicitly throwing exceptions for abnormal execution and Java style try/catch for exception handling.
    
    Above is the style recommendation. Please use try/catch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org