[Impala-ASF-CR] IMPALA-11606: Add the 'mem-tracker.process.bytes-untracked' metric.

["Xiang Yang (Code Review)" <ge...@cloudera.org>]

Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19029 )

Change subject: IMPALA-11606: Add the 'mem-tracker.process.bytes-untracked' metric.
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19029/9/be/src/runtime/mem-tracker.cc
File be/src/runtime/mem-tracker.cc:

http://gerrit.cloudera.org:8080/#/c/19029/9/be/src/runtime/mem-tracker.cc@402
PS9, Line 402: TODO
> Let's not forget that this should be resolved before merging this change :)
I found that if I sleep 10s in TestAdmissionController::test_timeout_reason_host_memory() without this patch, it failed as well, this is because the MemoryMaintenanceThread sleep 10s before refresh the process mem-tracker: https://github.com/apache/impala/blob/4.2.0/be/src/common/init.cc#L202, and after the refresh action, the consuption increased from 0 to ~175MB(I have to admit that I haven't figure out the memory calculate logic yet), but the expected 2MB. 
It looks like this testcase isn't implemented correctly.



-- 
To view, visit http://gerrit.cloudera.org:8080/19029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib16e00109d732f759c96c7a967eb1cc32124a03f
Gerrit-Change-Number: 19029
Gerrit-PatchSet: 9
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Sun, 14 May 2023 15:52:50 +0000
Gerrit-HasComments: Yes