[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #2030: IGNITE-19177 Add assignments checks when building indexes

["vldpyatkov (via GitHub)" <gi...@apache.org>]

vldpyatkov commented on code in PR #2030:
URL: https://github.com/apache/ignite-3/pull/2030#discussion_r1187256731


##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuilder.java:
##########
@@ -100,10 +111,14 @@ void stop() {
      */
     void startIndexBuild(TableIndexView tableIndexView, TableImpl table) {
         for (int partitionId = 0; partitionId < table.internalTable().partitions(); partitionId++) {
+            // Let's check if there is a node in the assignments for the partition.
+            if (!replicaManager.startedGroups().contains(new TablePartitionId(table.tableId(), partitionId))) {

Review Comment:
   The checking based on started replica does not look like a permanent solution. Because the replica is a consequence of assignments.
   If it is a temporary, that required TODO here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org