[GitHub] [spark] holdenk commented on a diff in pull request #38732: [SPARK-41210][K8S] Window based executor failure tracking mechanism

[GitBox <gi...@apache.org>]

holdenk commented on code in PR #38732:
URL: https://github.com/apache/spark/pull/38732#discussion_r1034165349


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala:
##########
@@ -136,6 +151,10 @@ class ExecutorPodsAllocator(
 
   def isDeleted(executorId: String): Boolean = deletedExecutorIds.contains(executorId.toLong)
 
+  private[k8s] def stopApplication(exitCode: Int): Unit = {
+    sys.exit(exitCode)
+  }

Review Comment:
   I'm not super sure on this logic here, generally speaking we want to do a more controlled shutdown than just a `sys.exit`, could we call into the shutdownhook like in YARN?
   
   Or is there a reason why were using sys.ext here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org