[GitHub] [hive] zabetak commented on a change in pull request #1780: HIVE-24534: Prevent comparisons between characters and decimals types when strict checks enabled

[GitBox <gi...@apache.org>]

zabetak commented on a change in pull request #1780:
URL: https://github.com/apache/hive/pull/1780#discussion_r559496100



##########
File path: ql/src/test/results/clientpositive/llap/avrotblsjoin.q.out
##########
@@ -71,9 +71,9 @@ POSTHOOK: Input: _dummy_database@_dummy_table
 POSTHOOK: Output: default@table1_1
 POSTHOOK: Lineage: table1_1.col1 SCRIPT []
 POSTHOOK: Lineage: table1_1.col2 SCRIPT []
-WARNING: Comparing a bigint and a string may result in a loss of precision.
-WARNING: Comparing a bigint and a string may result in a loss of precision.
-WARNING: Comparing a bigint and a string may result in a loss of precision.
+WARNING: Comparing string and bigint may result in loss of information.

Review comment:
       I changed the message `to loss of information` since precision may not make sense for certain types such as string. I don't have a strong preference though so I can restore the old message.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org