You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2023/02/28 14:52:27 UTC
[GitHub] [beam] damccorm opened a new pull request, #25661: Fix tensorflowhub caching issue
damccorm opened a new pull request, #25661:
URL: https://github.com/apache/beam/pull/25661
Right now, the tfhub test can fail because of a caching issue. When loading from tensorflow hub using tfhub.resolve, the model is saved in a temporary directory. That file can be persisted between test runs, in which case tfhub.resolve will no-op. If the model is deleted and the file isn't, tfhub.resolve will still no-op and tf.keras.models.load_model will throw.To avoid this (and test more robustly) we can delete the temporary directory entirely between runs.
This fixes the currently failing python 3.7 postcommit (along with https://github.com/apache/beam/pull/25654)
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #25661: Fix tensorflowhub caching issue
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #25661:
URL: https://github.com/apache/beam/pull/25661#issuecomment-1448321776
Run Python 3.7 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #25661: Fix tensorflowhub caching issue
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #25661:
URL: https://github.com/apache/beam/pull/25661#issuecomment-1448805506
Python postcommit failure isn't tensorflow - test_tf_imagenet_image_segmentation succeeded (other issue should be fixed by #25654).
Gradle publish issue is unrelated as well, that's part of the release and I just needed a PR on master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25661: Fix tensorflowhub caching issue
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25661:
URL: https://github.com/apache/beam/pull/25661#issuecomment-1448806747
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @tvalentyn for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #25661: Fix tensorflowhub caching issue
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #25661:
URL: https://github.com/apache/beam/pull/25661#issuecomment-1448805864
R: @riteshghorse @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #25661: Fix tensorflowhub caching issue
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #25661:
URL: https://github.com/apache/beam/pull/25661#issuecomment-1448377187
# [Codecov](https://codecov.io/gh/apache/beam/pull/25661?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#25661](https://codecov.io/gh/apache/beam/pull/25661?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (427776e) into [master](https://codecov.io/gh/apache/beam/commit/7db76df69361e1259f304e5781b299c83b78eab1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7db76df) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #25661 +/- ##
=======================================
Coverage 72.82% 72.82%
=======================================
Files 775 775
Lines 102928 102928
=======================================
Hits 74958 74958
Misses 26515 26515
Partials 1455 1455
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25661: Fix tensorflowhub caching issue
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25661:
URL: https://github.com/apache/beam/pull/25661#issuecomment-1448808086
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #25661: Fix tensorflowhub caching issue
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #25661:
URL: https://github.com/apache/beam/pull/25661#issuecomment-1448361944
Run Python 3.7 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #25661: Fix tensorflowhub caching issue
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #25661:
URL: https://github.com/apache/beam/pull/25661#issuecomment-1448380228
Run Gradle Publish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #25661: Fix tensorflowhub caching issue
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #25661:
URL: https://github.com/apache/beam/pull/25661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org