You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Nick Bailey (JIRA)" <ji...@apache.org> on 2012/10/04 19:47:47 UTC
[jira] [Created] (CASSANDRA-4764) Bulk Loading should run in
STREAM_STAGE
Nick Bailey created CASSANDRA-4764:
--------------------------------------
Summary: Bulk Loading should run in STREAM_STAGE
Key: CASSANDRA-4764
URL: https://issues.apache.org/jira/browse/CASSANDRA-4764
Project: Cassandra
Issue Type: Bug
Affects Versions: 1.2.0 beta 1
Reporter: Nick Bailey
Priority: Minor
Currently it appears as though bulk loading operations don't run in any stage. Seems like they should be running in STREAM_STAGE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4764) Bulk Loading should run in
STREAM_STAGE
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469722#comment-13469722 ]
Jonathan Ellis commented on CASSANDRA-4764:
-------------------------------------------
Do we need it? Would we count sessions or files or ranges?
> Bulk Loading should run in STREAM_STAGE
> ---------------------------------------
>
> Key: CASSANDRA-4764
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4764
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Nick Bailey
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: streaming
> Fix For: 1.2.0 beta 2
>
> Attachments: 4764.txt
>
>
> Currently it appears as though bulk loading operations don't run in any stage. Seems like they should be running in STREAM_STAGE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4764) Clean out STREAM_STAGE vestiges
Posted by "Yuki Morishita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481724#comment-13481724 ]
Yuki Morishita commented on CASSANDRA-4764:
-------------------------------------------
+1
> Clean out STREAM_STAGE vestiges
> -------------------------------
>
> Key: CASSANDRA-4764
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4764
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Nick Bailey
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: streaming
> Fix For: 1.2.0 beta 2
>
> Attachments: 4764.txt, 4764-v2.txt
>
>
> Currently it appears as though bulk loading operations don't run in any stage. Seems like they should be running in STREAM_STAGE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4764) Clean out STREAM_STAGE vestiges
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482349#comment-13482349 ]
Jonathan Ellis commented on CASSANDRA-4764:
-------------------------------------------
Reverted.
> Clean out STREAM_STAGE vestiges
> -------------------------------
>
> Key: CASSANDRA-4764
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4764
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Nick Bailey
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: streaming
> Fix For: 1.2.0 beta 2
>
> Attachments: 4764.txt, 4764-v2.txt
>
>
> Currently it appears as though bulk loading operations don't run in any stage. Seems like they should be running in STREAM_STAGE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4764) Bulk Loading should run in
STREAM_STAGE
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4764:
--------------------------------------
Attachment: 4764.txt
Looks like post-CASSANDRA-3494 Stage.STREAM is obsolete, since MessagingService has a per-target Executor for streams. Patch attached to clean out the vestiges.
> Bulk Loading should run in STREAM_STAGE
> ---------------------------------------
>
> Key: CASSANDRA-4764
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4764
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.2.0 beta 1
> Reporter: Nick Bailey
> Priority: Minor
> Attachments: 4764.txt
>
>
> Currently it appears as though bulk loading operations don't run in any stage. Seems like they should be running in STREAM_STAGE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4764) Clean out STREAM_STAGE vestiges
Posted by "Yuki Morishita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481556#comment-13481556 ]
Yuki Morishita commented on CASSANDRA-4764:
-------------------------------------------
For removing STREAM stage, +1.
Attached patch seems against 1.1 and contains diff from different issue though.
> Clean out STREAM_STAGE vestiges
> -------------------------------
>
> Key: CASSANDRA-4764
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4764
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Nick Bailey
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: streaming
> Fix For: 1.2.0 beta 2
>
> Attachments: 4764.txt
>
>
> Currently it appears as though bulk loading operations don't run in any stage. Seems like they should be running in STREAM_STAGE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4764) Bulk Loading should run in
STREAM_STAGE
Posted by "Nick Bailey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469730#comment-13469730 ]
Nick Bailey commented on CASSANDRA-4764:
----------------------------------------
Well just the number of completed tasks probably isn't particularly useful you are right.
I feel like we need some additional tracking around streaming though. Currently if streaming fails mid stream for bootstrap or move or decom and the like there isn't necessarily any indication that something went wrong unless you examine the logs. So more useful woud be successful count and failed count on a per session basis or something like that.
That is perhaps best decided in a different ticket though.
> Bulk Loading should run in STREAM_STAGE
> ---------------------------------------
>
> Key: CASSANDRA-4764
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4764
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Nick Bailey
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: streaming
> Fix For: 1.2.0 beta 2
>
> Attachments: 4764.txt
>
>
> Currently it appears as though bulk loading operations don't run in any stage. Seems like they should be running in STREAM_STAGE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4764) Bulk Loading should run in
STREAM_STAGE
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469746#comment-13469746 ]
Jonathan Ellis commented on CASSANDRA-4764:
-------------------------------------------
Yeah, it sounds like we're not really sure what we need. Maybe just return session id to the user so they can ask "hey, how's session X doing?"
> Bulk Loading should run in STREAM_STAGE
> ---------------------------------------
>
> Key: CASSANDRA-4764
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4764
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Nick Bailey
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: streaming
> Fix For: 1.2.0 beta 2
>
> Attachments: 4764.txt
>
>
> Currently it appears as though bulk loading operations don't run in any stage. Seems like they should be running in STREAM_STAGE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4764) Clean out STREAM_STAGE vestiges
Posted by "Yuki Morishita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482372#comment-13482372 ]
Yuki Morishita commented on CASSANDRA-4764:
-------------------------------------------
+1
(StreamReply is actually not handled in MISC stage but in FileStreamTask and streamExecutor now, but let's leave it here for later fix.)
> Clean out STREAM_STAGE vestiges
> -------------------------------
>
> Key: CASSANDRA-4764
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4764
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Nick Bailey
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: streaming
> Fix For: 1.2.0 beta 2
>
> Attachments: 4764.txt, 4764-v2.txt, 4764-v3.txt
>
>
> Currently it appears as though bulk loading operations don't run in any stage. Seems like they should be running in STREAM_STAGE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4764) Bulk Loading should run in
STREAM_STAGE
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4764:
--------------------------------------
Reviewer: yukim
Affects Version/s: (was: 1.2.0 beta 1)
1.1.0
Fix Version/s: 1.2.0 beta 2
Assignee: Jonathan Ellis
Labels: streaming (was: )
> Bulk Loading should run in STREAM_STAGE
> ---------------------------------------
>
> Key: CASSANDRA-4764
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4764
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Nick Bailey
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: streaming
> Fix For: 1.2.0 beta 2
>
> Attachments: 4764.txt
>
>
> Currently it appears as though bulk loading operations don't run in any stage. Seems like they should be running in STREAM_STAGE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-4764) Clean out STREAM_STAGE vestiges
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-4764.
---------------------------------------
Resolution: Fixed
committed, w/ comment for STREAM_REPLY
> Clean out STREAM_STAGE vestiges
> -------------------------------
>
> Key: CASSANDRA-4764
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4764
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Nick Bailey
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: streaming
> Fix For: 1.2.0 beta 2
>
> Attachments: 4764.txt, 4764-v2.txt, 4764-v3.txt
>
>
> Currently it appears as though bulk loading operations don't run in any stage. Seems like they should be running in STREAM_STAGE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4764) Clean out STREAM_STAGE vestiges
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4764:
--------------------------------------
Summary: Clean out STREAM_STAGE vestiges (was: Bulk Loading should run in STREAM_STAGE)
> Clean out STREAM_STAGE vestiges
> -------------------------------
>
> Key: CASSANDRA-4764
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4764
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Nick Bailey
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: streaming
> Fix For: 1.2.0 beta 2
>
> Attachments: 4764.txt
>
>
> Currently it appears as though bulk loading operations don't run in any stage. Seems like they should be running in STREAM_STAGE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4764) Clean out STREAM_STAGE vestiges
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4764:
--------------------------------------
Attachment: 4764-v2.txt
clean v2 attached against trunk
> Clean out STREAM_STAGE vestiges
> -------------------------------
>
> Key: CASSANDRA-4764
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4764
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Nick Bailey
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: streaming
> Fix For: 1.2.0 beta 2
>
> Attachments: 4764.txt, 4764-v2.txt
>
>
> Currently it appears as though bulk loading operations don't run in any stage. Seems like they should be running in STREAM_STAGE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4764) Clean out STREAM_STAGE vestiges
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4764:
--------------------------------------
Attachment: 4764-v3.txt
v3 attached w/ fix.
> Clean out STREAM_STAGE vestiges
> -------------------------------
>
> Key: CASSANDRA-4764
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4764
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Nick Bailey
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: streaming
> Fix For: 1.2.0 beta 2
>
> Attachments: 4764.txt, 4764-v2.txt, 4764-v3.txt
>
>
> Currently it appears as though bulk loading operations don't run in any stage. Seems like they should be running in STREAM_STAGE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CASSANDRA-4764) Clean out STREAM_STAGE vestiges
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne reopened CASSANDRA-4764:
-----------------------------------------
That has completely broke bootstrap by removing Verb.STREAM_REQUEST from the list of known verbs in MessagingService (and StreamRequests were executed on teh stream stage, which we can change I suppose).
> Clean out STREAM_STAGE vestiges
> -------------------------------
>
> Key: CASSANDRA-4764
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4764
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Nick Bailey
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: streaming
> Fix For: 1.2.0 beta 2
>
> Attachments: 4764.txt, 4764-v2.txt
>
>
> Currently it appears as though bulk loading operations don't run in any stage. Seems like they should be running in STREAM_STAGE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4764) Bulk Loading should run in
STREAM_STAGE
Posted by "Nick Bailey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469714#comment-13469714 ]
Nick Bailey commented on CASSANDRA-4764:
----------------------------------------
So the reason i noticed this is because we bulk loads weren't showing up in the stream stage mbean. It sounds like nothing will show up there though. Removing the stage is good so that the mbean doesn't show up at all anymore but should we make a ticket to expose similar stats from messaging service?
I guess the only thing that mbean provided that the streaming service mbean doesn't is completed tasks. So maybe just add a counter there?
> Bulk Loading should run in STREAM_STAGE
> ---------------------------------------
>
> Key: CASSANDRA-4764
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4764
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Nick Bailey
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: streaming
> Fix For: 1.2.0 beta 2
>
> Attachments: 4764.txt
>
>
> Currently it appears as though bulk loading operations don't run in any stage. Seems like they should be running in STREAM_STAGE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira