You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/18 06:35:53 UTC
[GitHub] [pulsar] codelipenghui commented on a change in pull request #12874: [broker] Optimize blocking backlogQuotaCheck to non-blocking in ServerCnx#handleProducer
codelipenghui commented on a change in pull request #12874:
URL: https://github.com/apache/pulsar/pull/12874#discussion_r786449282
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -1188,69 +1189,75 @@ protected void handleProducer(final CommandProducer cmdProducer) {
log.info("[{}][{}] Creating producer. producerId={}", remoteAddress, topicName, producerId);
- service.getOrCreateTopic(topicName.toString()).thenAccept((Topic topic) -> {
+ service.getOrCreateTopic(topicName.toString()).thenCompose((Topic topic) -> {
// Before creating producer, check if backlog quota exceeded
// on topic for size based limit and time based limit
- for (BacklogQuota.BacklogQuotaType backlogQuotaType : BacklogQuota.BacklogQuotaType.values()) {
- if (topic.isBacklogQuotaExceeded(producerName, backlogQuotaType)) {
- IllegalStateException illegalStateException = new IllegalStateException(
- "Cannot create producer on topic with backlog quota exceeded");
- BacklogQuota.RetentionPolicy retentionPolicy = topic
- .getBacklogQuota(backlogQuotaType).getPolicy();
- if (retentionPolicy == BacklogQuota.RetentionPolicy.producer_request_hold) {
- commandSender.sendErrorResponse(requestId,
- ServerError.ProducerBlockedQuotaExceededError,
- illegalStateException.getMessage());
- } else if (retentionPolicy == BacklogQuota.RetentionPolicy.producer_exception) {
- commandSender.sendErrorResponse(requestId,
- ServerError.ProducerBlockedQuotaExceededException,
- illegalStateException.getMessage());
- }
- producerFuture.completeExceptionally(illegalStateException);
- producers.remove(producerId, producerFuture);
- return;
+ CompletableFuture<Void> backlogQuotaCheckFuture = CompletableFuture.allOf(
+ topic.checkBacklogQuotaExceeded(producerName, BacklogQuotaType.destination_storage),
+ topic.checkBacklogQuotaExceeded(producerName, BacklogQuotaType.message_age));
+ backlogQuotaCheckFuture.exceptionally(throwable -> {
Review comment:
`thenCompose` return the `backlogQuotaCheckFuture` to the next stage, is it better to handle the `TopicBacklogQuotaExceededException` here https://github.com/apache/pulsar/pull/12874/files#diff-1e0e8195fb5ec5a6d79acbc7d859c025a9b711f94e6ab37c94439e99b3202e84R1262 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org