You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/06/30 22:09:50 UTC
[GitHub] [solr-operator] mogul opened a new issue #277: Start using v1 of the k8s networking API for ingress
mogul opened a new issue #277:
URL: https://github.com/apache/solr-operator/issues/277
The k8s.io/api/networking/v1beta1 API is unsupported in the latest versions of `nginx-ingress`, and the API will be unsupported from k8s 1.22.0+ For future-proofing against breakage, the solr-operator should start using k8s.io/api/networking/v1 to specify ingresses.
(Note v1 has only been supported since k8s 1.19.0+, so switching to using v1 would limit solr-operator to supporting 1.19.0+, unless you add special support for using v1beta1 on earlier versions, which could get messy to maintain.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on issue #277: Use v1 of the k8s networking and extension APIs
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on issue #277:
URL: https://github.com/apache/solr-operator/issues/277#issuecomment-876532088
Note, when we make 1.19 the minimum kubernetes version supported, we can officially add support for the [Pod Topology Spread Constraints](https://kubernetes.io/docs/concepts/workloads/pods/pod-topology-spread-constraints/) 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on issue #277: Use v1 of the k8s networking and extension APIs
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on issue #277:
URL: https://github.com/apache/solr-operator/issues/277#issuecomment-874757470
Agreed. I was waiting to make the change until it was reasonable to make 1.19 the minimum supported kubernetes version. I think once 1.22 is released we can make this change and stage it for the next minor release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on issue #277: Use v1 of the k8s networking and extension APIs
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on issue #277:
URL: https://github.com/apache/solr-operator/issues/277#issuecomment-922990955
So we do use KinD for our integration Smoke Tests, and will definitely use it in the future whenever we introduce integration tests (#134). However the EnvTest setup is used for unit tests for Kubebuilder projects. It's not an actual kubernetes cluster, like DockerDesktop or KinD. It's a custom stripped down version of the API Server.
With the Upgrade to Kubebuilder 3, we will actually be able to test with any version of the EnvTest Kubernetes version (So we will be able to test with multiple versions, just like KinD), but for now we are stuck with a very old version that shipped with Kubebuilder 2. I believe after the upgrade, the unit tests will actually be able to work with a real Kubernetes cluster as well (but our unit tests do not support this currently.), if you want to run the unit tests with your KinD cluster.
The PR for the Kubebuilder upgrade is far to big to parse (#321), but good progress is being made. And hopefully we will be able to cut a v0.5.0 fairly shortly (maybe within a month or month and a half) to support the new Kubernetes versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] chubbard commented on issue #277: Use v1 of the k8s networking and extension APIs
Posted by GitBox <gi...@apache.org>.
chubbard commented on issue #277:
URL: https://github.com/apache/solr-operator/issues/277#issuecomment-901094692
Since 1.22 is now officially out and 1.22.1 is coming out on 8/19/2021 when will upgrading from beta to v1 take place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] mogul commented on issue #277: Use v1 of the k8s networking and extension APIs
Posted by GitBox <gi...@apache.org>.
mogul commented on issue #277:
URL: https://github.com/apache/solr-operator/issues/277#issuecomment-922649960
I'm not sure I understand the constraint you're facing here...
> However the env-test that we use to spin up a "test" kubernetes cluster for our unit-tests uses a built-in binary of a test API server built before networking/v1 was introduced. So that means that we have to upgrade many dependencies, and possibly the entire version of Kubebuilder that we are using.
However, in case it helps: We use [KinD](https://kind.sigs.k8s.io/) to provision clusters where we develop and run tests that use the `solr-operator`. This has been better for us than using the Docker Desktop because then we have tight control over which version of k8s we're working with, and the same tooling is used during CI/CD under GitHub Actions (where Docker Desktop isn't available).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] mogul commented on issue #277: Use v1 of the k8s networking and extension APIs
Posted by GitBox <gi...@apache.org>.
mogul commented on issue #277:
URL: https://github.com/apache/solr-operator/issues/277#issuecomment-929839875
Great to see this addressed. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] mogul commented on issue #277: Use v1 of the k8s networking and extension APIs
Posted by GitBox <gi...@apache.org>.
mogul commented on issue #277:
URL: https://github.com/apache/solr-operator/issues/277#issuecomment-929839875
Great to see this addressed. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] mogul commented on issue #277: Use v1 of the k8s networking API for ingress
Posted by GitBox <gi...@apache.org>.
mogul commented on issue #277:
URL: https://github.com/apache/solr-operator/issues/277#issuecomment-871769531
Looks like the same situation applies for `apiextensions.k8s.io/v1beta1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman closed issue #277: Use v1 of the k8s networking and extension APIs
Posted by GitBox <gi...@apache.org>.
HoustonPutman closed issue #277:
URL: https://github.com/apache/solr-operator/issues/277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] chubbard commented on issue #277: Use v1 of the k8s networking and extension APIs
Posted by GitBox <gi...@apache.org>.
chubbard commented on issue #277:
URL: https://github.com/apache/solr-operator/issues/277#issuecomment-901094692
Since 1.22 is now officially out and 1.22.1 is coming out on 8/19/2021 when will upgrading from beta to v1 take place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] mogul edited a comment on issue #277: Use v1 of the k8s networking and extension APIs
Posted by GitBox <gi...@apache.org>.
mogul edited a comment on issue #277:
URL: https://github.com/apache/solr-operator/issues/277#issuecomment-922649960
I'm not sure I understand the constraint you're facing here...
> However the env-test that we use to spin up a "test" kubernetes cluster for our unit-tests uses a built-in binary of a test API server built before networking/v1 was introduced. So that means that we have to upgrade many dependencies, and possibly the entire version of Kubebuilder that we are using.
However, in case it helps: We use [KinD](https://kind.sigs.k8s.io/) to provision clusters where we develop and run tests that use the `solr-operator`. This has been better for us than using the Docker Desktop because then we have tight control over which version of k8s we're working with, and the same tooling is used during CI/CD under GitHub Actions (where Docker Desktop isn't available). You can see how we set up the environment [here](https://github.com/GSA/datagov-brokerpak/blob/831d68833bf98aeeba518c03d360822316f20f48/Makefile#L95-L115). (We're just making the change to 0.4.0 now.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on issue #277: Use v1 of the k8s networking and extension APIs
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on issue #277:
URL: https://github.com/apache/solr-operator/issues/277#issuecomment-906671538
So I took a stab at making this work. It seemingly would be very easy to just replace the networking/v1beta1 dependency with networking/v1. However the `env-test` that we use to spin up a "test" kubernetes cluster for our unit-tests uses a built-in binary of a test API server built before `networking/v1` was introduced. So that means that we have to upgrade many dependencies, and possibly the entire version of Kubebuilder that we are using.
In addition, when those dependencies are updated (sloppily at best), and things "work", the zookeeper-operator dependency is built with an older version of controller-runtime that is not compatible with the new version. This means that we cannot import the zookeeper-operator code, which is not possible in the current state of the project.
We will definitely need to solve this issue for the `v0.5.0` release, but unfortunately it's too big of an undertaking to take on for `v0.4.0`.
Sorry for the inconvenience this causes anyone. We hope to be able to support Kubernetes 1.22 as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman closed issue #277: Use v1 of the k8s networking and extension APIs
Posted by GitBox <gi...@apache.org>.
HoustonPutman closed issue #277:
URL: https://github.com/apache/solr-operator/issues/277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org