You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "BiteTheDDDDt (via GitHub)" <gi...@apache.org> on 2023/12/28 09:13:45 UTC
[PR] optimize for ColumnNullable's serialize_vec/deserialize_vec [doris]
BiteTheDDDDt opened a new pull request, #29232:
URL: https://github.com/apache/doris/pull/29232
## Proposed changes
pick from #28788
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] optimize for ColumnNullable's serialize_vec/deserialize_vec [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #29232:
URL: https://github.com/apache/doris/pull/29232#discussion_r1437505067
##########
be/src/vec/core/column_with_type_and_name.cpp:
##########
@@ -87,4 +88,28 @@ void ColumnWithTypeAndName::to_pb_column_meta(PColumnMeta* col_meta) const {
type->to_pb_column_meta(col_meta);
}
+ColumnWithTypeAndName ColumnWithTypeAndName::get_nested(bool replace_null_data_to_default) const {
Review Comment:
warning: method 'get_nested' can be made static [readability-convert-member-functions-to-static]
be/src/vec/core/column_with_type_and_name.h:67:
```diff
- ColumnWithTypeAndName get_nested(bool replace_null_data_to_default = false) const;
+ static ColumnWithTypeAndName get_nested(bool replace_null_data_to_default = false) ;
```
```suggestion
ColumnWithTypeAndName ColumnWithTypeAndName::get_nested(bool replace_null_data_to_default) {
```
##########
be/src/exprs/bloom_filter_func.h:
##########
@@ -392,9 +405,9 @@ struct StringFindOp : CommonFindOp<StringRef> {
// We do not need to judge whether data is empty, because null will not appear
// when filer used by the storage engine
struct FixedStringFindOp : public StringFindOp {
- uint16_t find_batch_olap_engine(const BloomFilterAdaptor& bloom_filter, const char* data,
- const uint8* nullmap, uint16_t* offsets, int number,
- const bool is_parse_column) {
+ static uint16_t find_batch_olap_engine(const BloomFilterAdaptor& bloom_filter, const char* data,
+ const uint8* nullmap, uint16_t* offsets, int number,
Review Comment:
warning: pointer parameter 'offsets' can be pointer to const [readability-non-const-parameter]
```suggestion
const uint8* nullmap, const uint16_t* offsets, int number,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] optimize for ColumnNullable's serialize_vec/deserialize_vec [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #29232:
URL: https://github.com/apache/doris/pull/29232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org