[GitHub] [skywalking-java] lujiajing1126 commented on pull request #445: refactor pipeline in jedis-plugin

["lujiajing1126 (via GitHub)" <gi...@apache.org>]

lujiajing1126 commented on PR #445:
URL: https://github.com/apache/skywalking-java/pull/445#issuecomment-1409906220

   > BTW, are you going to refactor jedis 4.x plugin?
   
   I found that in the current jedis 4.x plugin, the interception point seems to be weird. 
   
   `Connection.sendCommand` only appends command to the `RedisOutputStream` which is a buffer(by default `8 KiB`). The real round-trip happens when `flush()` is called. So as I understand, we are now measuring the TCP connection time to the Redis server rather than the execution time of the real command. Can you pls make a confirmation?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org