You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by sravan-s <gi...@git.apache.org> on 2017/03/01 15:46:06 UTC
[GitHub] zeppelin pull request #2087: [ZEPPELIN-2172] Redirect to home if notebook au...
GitHub user sravan-s opened a pull request:
https://github.com/apache/zeppelin/pull/2087
[ZEPPELIN-2172] Redirect to home if notebook authentication fails in realtime
### What is this PR for?
Redirect to home page, if a user declines the access failure message on a notebook
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-2172](https://issues.apache.org/jira/browse/ZEPPELIN-2172)
### How should this be tested?
1. Create a notebook with qa_user user as the owner
2. Give write permissions to user test_user1, and read permissions to user test_user3
3. Now in another tab, open the notebook with test_user1 user who has write permissions
4. In the original tab, have user qa_user (owner of the notebook) remove the write permissions from test_user1 user and grant it to some other user test_user5.
5. Goto the other tab where user test_user1 was logged in. It shows an error message
6. On click of close button, UI should redirect to homepage
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sravan-s/zeppelin ZEPPELIN-2172
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2087.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2087
----
commit b73cc7364bf0121ff26a7599198f7365cccad92c
Author: ess_ess <sr...@gmail.com>
Date: 2017-03-01T15:11:39Z
[ZEPPELIN-2172] Redirect to home if auth fails
If someone restricts the access to a notebook in
realtime, show proper error messsage. If user
chooses not to login, redirect to home page
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:
https://github.com/apache/zeppelin/pull/2087
@leemoonsoo
Its ess_ess
By the way please check 1889
https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ess_ess
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:
https://github.com/apache/zeppelin/pull/2087
What I was able to find was that, if you put something like `$location.path` inside `BootstrapDialog.show`, it won't trigger angular digest cycle. Please take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:
https://github.com/apache/zeppelin/pull/2087
Let me try that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2087
@sravan-s You can create or leave comment to JIRA issue. Or you can always email dev@zeppelin.apache.org
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:
https://github.com/apache/zeppelin/pull/2087
@Leemoonsoo The CI is green now
Is it okay if I try to work on some other bugs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2087: [ZEPPELIN-2172] Redirect to home if notebook au...
Posted by sravan-s <gi...@git.apache.org>.
GitHub user sravan-s reopened a pull request:
https://github.com/apache/zeppelin/pull/2087
[ZEPPELIN-2172] Redirect to home if notebook authentication fails in realtime
### What is this PR for?
Redirect to home page, if a user declines the access failure message on a notebook
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-2172](https://issues.apache.org/jira/browse/ZEPPELIN-2172)
### How should this be tested?
1. Create a notebook with qa_user user as the owner
2. Give write permissions to user test_user1, and read permissions to user test_user3
3. Now in another tab, open the notebook with test_user1 user who has write permissions
4. In the original tab, have user qa_user (owner of the notebook) remove the write permissions from test_user1 user and grant it to some other user test_user5.
5. Goto the other tab where user test_user1 was logged in. It shows an error message
6. On click of close button, UI should redirect to homepage
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sravan-s/zeppelin ZEPPELIN-2172
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2087.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2087
----
commit b73cc7364bf0121ff26a7599198f7365cccad92c
Author: ess_ess <sr...@gmail.com>
Date: 2017-03-01T15:11:39Z
[ZEPPELIN-2172] Redirect to home if auth fails
If someone restricts the access to a notebook in
realtime, show proper error messsage. If user
chooses not to login, redirect to home page
commit 0b9b1dd1f2b2f739ef64b730f6be1f67c8767c53
Author: ess_ess <sr...@gmail.com>
Date: 2017-03-05T10:47:39Z
Add explanatory comment
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2087: [ZEPPELIN-2172] Redirect to home if notebook au...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s closed the pull request at:
https://github.com/apache/zeppelin/pull/2087
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2087
@sravan-s Can i know your JIRA ID? So i can resolve ZEPPELIN-2172 with your name in assignee.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2087: [ZEPPELIN-2172] Redirect to home if notebook au...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s closed the pull request at:
https://github.com/apache/zeppelin/pull/2087
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:
https://github.com/apache/zeppelin/pull/2087
@Leemoonsoo Who is the go to person at JIRA, if I need to ask clear some of my doubts. I found some interesting bugs, but, I would like to verify some of my doubts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2087
@sravan-s Thanks, that would be helpful!
LGTM and merge to master and branch-0.7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2087
@sravan-s Good catch! Tested as you described and it works well.
If your own account CI has been passed, you can make this PR to green light by closing & reopening it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2087: [ZEPPELIN-2172] Redirect to home if notebook au...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2087
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2087: [ZEPPELIN-2172] Redirect to home if notebook au...
Posted by sravan-s <gi...@git.apache.org>.
GitHub user sravan-s reopened a pull request:
https://github.com/apache/zeppelin/pull/2087
[ZEPPELIN-2172] Redirect to home if notebook authentication fails in realtime
### What is this PR for?
Redirect to home page, if a user declines the access failure message on a notebook
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-2172](https://issues.apache.org/jira/browse/ZEPPELIN-2172)
### How should this be tested?
1. Create a notebook with qa_user user as the owner
2. Give write permissions to user test_user1, and read permissions to user test_user3
3. Now in another tab, open the notebook with test_user1 user who has write permissions
4. In the original tab, have user qa_user (owner of the notebook) remove the write permissions from test_user1 user and grant it to some other user test_user5.
5. Goto the other tab where user test_user1 was logged in. It shows an error message
6. On click of close button, UI should redirect to homepage
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sravan-s/zeppelin ZEPPELIN-2172
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2087.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2087
----
commit b73cc7364bf0121ff26a7599198f7365cccad92c
Author: ess_ess <sr...@gmail.com>
Date: 2017-03-01T15:11:39Z
[ZEPPELIN-2172] Redirect to home if auth fails
If someone restricts the access to a notebook in
realtime, show proper error messsage. If user
chooses not to login, redirect to home page
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:
https://github.com/apache/zeppelin/pull/2087
Yes, I have setup my travis. It got triggered and is green when I raised a PR to my fork's master branch(the master branch isn't modified) https://travis-ci.org/sravan-s/zeppelin/builds/206654715
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2087: [ZEPPELIN-2172] Redirect to home if notebook au...
Posted by sravan-s <gi...@git.apache.org>.
GitHub user sravan-s reopened a pull request:
https://github.com/apache/zeppelin/pull/2087
[ZEPPELIN-2172] Redirect to home if notebook authentication fails in realtime
### What is this PR for?
Redirect to home page, if a user declines the access failure message on a notebook
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-2172](https://issues.apache.org/jira/browse/ZEPPELIN-2172)
### How should this be tested?
1. Create a notebook with qa_user user as the owner
2. Give write permissions to user test_user1, and read permissions to user test_user3
3. Now in another tab, open the notebook with test_user1 user who has write permissions
4. In the original tab, have user qa_user (owner of the notebook) remove the write permissions from test_user1 user and grant it to some other user test_user5.
5. Goto the other tab where user test_user1 was logged in. It shows an error message
6. On click of close button, UI should redirect to homepage
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sravan-s/zeppelin ZEPPELIN-2172
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2087.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2087
----
commit b73cc7364bf0121ff26a7599198f7365cccad92c
Author: ess_ess <sr...@gmail.com>
Date: 2017-03-01T15:11:39Z
[ZEPPELIN-2172] Redirect to home if auth fails
If someone restricts the access to a notebook in
realtime, show proper error messsage. If user
chooses not to login, redirect to home page
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2087
@sravan-s To make Zeppelin's Jenkins check your travis-ci build status correctly, you'll need to turn on 'Build pushes' switch from https://travis-ci.org/sravan-s/zeppelin/settings.
Then every push is going to be build and Zeppelin's Jenkins can check and display build status correctly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2087: [ZEPPELIN-2172] Redirect to home if notebook au...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s closed the pull request at:
https://github.com/apache/zeppelin/pull/2087
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:
https://github.com/apache/zeppelin/pull/2087
@Leemoonsoo Those buttons are on. I'm not sure why travis isn't picking this up.
This is my travis settings:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2087
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---