[jira] [Commented] (PHOENIX-5629) Phoenix Function to Return HBase row timestamp

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029209#comment-17029209 ] 

Hadoop QA commented on PHOENIX-5629:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12992516/PHOENIX-5629.4.x-HBase-1.3.v1.patch
  against 4.x-HBase-1.3 branch at commit b27168de1922d429229935b16eef49c00a88aab1.
  ATTACHMENT ID: 12992516

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +    public RowTimestampStringFunctionIT(QualifierEncodingScheme encoding, ImmutableStorageScheme storage) {
+    private void verifyHbaseAllRowsTimestamp(String tableName, ResultSet rs, int expectedRowCount) throws Exception {
+        try (org.apache.hadoop.hbase.client.Connection hconn = ConnectionFactory.createConnection(config)) {
+                long timeStamp = result.getColumnLatestCell(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES, emptyKVQualifier).getTimestamp();
+    private void verifyHbaseRowTimestamp(String tableName, String rowKey, Date expectedTimestamp) throws Exception {
+        try (org.apache.hadoop.hbase.client.Connection hconn = ConnectionFactory.createConnection(config)) {
+            long timeStamp = result.getColumnLatestCell(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES, emptyKVQualifier).getTimestamp();
+                    + " (PK INTEGER NOT NULL PRIMARY KEY, KV1 VARCHAR, KV2 VARCHAR)" + this.tableDDLOptions;

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3382//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3382//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3382//console

This message is automatically generated.

> Phoenix Function to Return HBase row timestamp
> ----------------------------------------------
>
>                 Key: PHOENIX-5629
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5629
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Geoffrey Jacoby
>            Assignee: Tanuj Khurana
>            Priority: Major
>             Fix For: 5.1.0, 4.16.0
>
>         Attachments: PHOENIX-5629.4.x-HBase-1.3.v1.patch, PHOENIX-5629.master.v1.patch
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> t's occasionally useful when diagnosing an issue with Phoenix to be able to easily look up the HBase timestamp of the HBase Cell returned by a Phoenix query. 
> For example:
> SELECT ROW_TIMESTAMP(Column1) FROM Table1 WHERE Column1 = 'SomeValue'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)