[jira] [Commented] (OFBIZ-9981) Handle service response effectively

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730107#comment-16730107 ] 

Jacques Le Roux commented on OFBIZ-9981:
----------------------------------------

Hi Suraj,

Sorry I did not continue to work on applying my idea of pattern everywhere, but I did not forget. I like your idea of adding a module parameter to {{returnProblem}} and so to all {{return*}} methods of ServiceUtil class. I don't think it needs another Jira, it perfectly fits here. Maybe a discussion in dev ML, because it entails a lot of, fortunately trivial, changes. Thanks!

> Handle service response effectively
> -----------------------------------
>
>                 Key: OFBIZ-9981
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9981
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Suraj Khurana
>            Assignee: Jacques Le Roux
>            Priority: Major
>         Attachments: OFBIZ-9981-MAR-SECEXT-WE.patch, OFBIZ-9981-content.patch, OFBIZ-9981-manufacturing.patch, OFBIZ-9981-order.patch, OFBIZ-9981-party.patch, OFBIZ-9981-plugins.patch, OFBIZ-9981-product.patch, OFBIZ-9981.patch
>
>
> [As per discussion on Dev ML|http://markmail.org/message/dfriai337uxlx5mo]: 
> ==========================
> Every service calling from java/groovy must handle errors by service util methods such as isError, reutrnError etc. and similarly in case of XML <call-service, there should be <check-error/> to make sure service was executed successfully.
> Apart from this, one suggestion is to include *Debug.logError* in *_ServiceUtil.returnProblem_* so that in case of any error occurred and handled, it will always be logged on the console.
> ==========================



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)